Nutrient enabled FATES API #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgknox
added
FATES API update
5 tasks
…s and FATES specific soil BGC calls. This allows for processing of high frequency history diagnostics before calls to fates dynamics, which will cause havoc on cohorts and their subsequent creation/dissapearance.
…a testmod dir that activates its namelist entry
glemieux
requested changes
Sep 21, 2020
src/main/clm_driver.F90
Outdated
| end if ! use_fates branch | ||
|
|
||
|
|
||
| if ( use_fates ) then |
There was a problem hiding this comment.
There's an empty if ... end if logic set here. I'm guessing it was old code that just got missed.
There was a problem hiding this comment.
yeah, good catch, I can remove this
src/utils/clmfates_interfaceMod.F90
Outdated
| @@ -874,7 +909,7 @@ subroutine dynamics_driv(this, nc, bounds_clump, & | |||
|
|
|||
| ! --------------------------------------------------------------------------------- | |||
| ! Part III.2 (continued). | |||
| ! Update diagnostics of the FATES ecosystem structure that are used in the HLM. | |||
| ! Update UpdateLdiagnostics of the FATES ecosystem structure that are used in the HLM. | |||
…riable from fates allvars test list
Cleanup typo and empty logic set
glemieux
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This enables API compliance with changes to FATES that enable nutrient dynamics. This code does not fully couple nutrients between the plants and soil. This API update will however allow for simulations and tests with prescribed nutrient uptake by plants.
Specific notes
Synchronized with FATES PR: NGEET/fates#598
FATES does now have a test mode that runs with C+N+P. However, this uses prescribed uptake rates on fates and breaks mass coupling with CTSM. This is our only option until we have a full nutrient model enabled.
Contributors other than yourself, if any: @ckoven @rosiealice @qzhu-lbl many others
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)?
yes, answers will change. Enough code is changed that I do expect round-off errors and non-b4b results, but the carbon-only version of FATES-CLM should produce indistinguishable results from a base.
Any User Interface Changes (namelist or namelist defaults changes)?
yes, a new FATES default parameter file will be generated. Pending discussion, the format of the file may or may not change.
Testing performed, if any:
TBD
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on cheyenne for intel/gnu and izumi for intel/gnu/nag/pgi is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).