Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncomment fates_hdim_levleaf dimension #1562

Merged
merged 9 commits into from
Jan 17, 2022

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 24, 2021

Description of changes

This reverts commit 5e1adf8.

And hence fixed #1561 by uncommenting fates_levleaf dimension.

This PR corresponds to the fates PR NGEET/fates#752.

Specific notes

Contributors other than yourself, if any: @glemieux @adrifoster

CTSM Issues Fixed (include github issue #):
Fixes #1561
Fixes #1485

Are answers expected to change (and if so in what way)? FATES only for field list, one test has roundoff level differences
SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesColdDefHydro

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: None so far, will run regular tests
Test should be identical. FATES tests should only be different due to field list.

… version"

This reverts commit 5e1adf8.

And hence fixed ESCOMP#1561 by uncommenting fates_levleaf dimension.
@ekluzek ekluzek added the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Nov 24, 2021
@ekluzek ekluzek self-assigned this Nov 24, 2021
@ekluzek ekluzek removed the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Nov 24, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 24, 2021

Since this requires a FATES PR that hasn't come in yet, we will hold off on this and bring it in with another FATES update.

@ekluzek ekluzek marked this pull request as draft November 24, 2021 20:00
@glemieux glemieux marked this pull request as ready for review December 17, 2021 18:03
@glemieux glemieux mentioned this pull request Dec 21, 2021
5 tasks
@glemieux
Copy link
Collaborator

glemieux commented Jan 13, 2022

The aux_clm tests on cheyenne are all b4b against the dev070 baseline, with two exceptions. The DIFF for the one FatesHydro with very small (E-19) differences that are expected per NGEET/fates#752. I'm seeing a failure for SMS_D_Ld9.f09_g17.I1850Clm50BgcNoAnthro.cheyenne_intel.clm-decStart1851_noinitial which has a pretty large stack trace that I won't reproduce here. It looks like it might be an issue with ESMF? The location of the test suite is here: /glade/u/home/glemieux/scratch/ctsm-tests/tests_vaibin-ctsmdev070-auxclm.

Testing on izumi is in progress.

@glemieux
Copy link
Collaborator

glemieux commented Jan 13, 2022

Izumi test results look good. All expected aux_clm and fates tests all pass b4b. The one DIFF in the FATES suite is a hydro testmod with expected very small differences. Folder locations:
/scratch/cluster/glemieux/ctsm-tests/tests_vai-bin-aux_clm
/scratch/cluster/glemieux/ctsm-tests/tests_vai-bin-fates

@glemieux
Copy link
Collaborator

I'm seeing a failure for SMS_D_Ld9.f09_g17.I1850Clm50BgcNoAnthro.cheyenne_intel.clm-decStart1851_noinitial which has a pretty large stack trace that I won't reproduce here. It looks like it might be an issue with ESMF?

Upon re-submission the test passes b4b.

@glemieux
Copy link
Collaborator

Re-running tests as we decided to integrate the fates ers sp mode fix (NGEET/fates#821) prior to integrating the this PR.

Izumi: All expected aux_clm tests pass B4B: /scratch/cluster/glemieux/ctsm-tests/tests_vai-bin-aux_clm-ersfix

Cheyenne:
All expected aux_clm tests pass B4B, with the exception of one fates hydro testmod DIFF, which has been deemed acceptable per NGEET/fates#752 (comment). There was a bit of a 'hiccup' that seemed to cause a few fine resolution grids to hit the wall clock time, but upon re-submission, they all complete with an expected run time. My suspicion that it was a temporary machine issue is given that the testmods affected were pretty disparate in setup aside from the grid size.
Test location: /glade/u/home/glemieux/scratch/ctsm-tests/tests_vaibin-ctsmdev070-auxclm-ersfix

@glemieux glemieux linked an issue Jan 15, 2022 that may be closed by this pull request
@ekluzek ekluzek added FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete labels Jan 17, 2022
@ekluzek ekluzek merged commit bcb9735 into ESCOMP:master Jan 17, 2022
@ekluzek ekluzek deleted the fix_fates_levleaf branch January 17, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FATES API update Changes to the FATES version that also REQUIRE an API change in CTSM PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uncomment fates_levleaf fields Forthcoming FATES satellite phenology ERS test fails
2 participants