-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncomment fates_hdim_levleaf dimension #1562
Conversation
… version" This reverts commit 5e1adf8. And hence fixed ESCOMP#1561 by uncommenting fates_levleaf dimension.
Since this requires a FATES PR that hasn't come in yet, we will hold off on this and bring it in with another FATES update. |
The Testing on izumi is in progress. |
Izumi test results look good. All expected |
Upon re-submission the test passes b4b. |
….52.1_api.20.0.0 update
Re-running tests as we decided to integrate the fates ers sp mode fix (NGEET/fates#821) prior to integrating the this PR. Izumi: All expected Cheyenne: |
Description of changes
This reverts commit 5e1adf8.
And hence fixed #1561 by uncommenting fates_levleaf dimension.
This PR corresponds to the fates PR NGEET/fates#752.
Specific notes
Contributors other than yourself, if any: @glemieux @adrifoster
CTSM Issues Fixed (include github issue #):
Fixes #1561
Fixes #1485
Are answers expected to change (and if so in what way)? FATES only for field list, one test has roundoff level differences
SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.cheyenne_intel.clm-FatesColdDefHydro
Any User Interface Changes (namelist or namelist defaults changes)? No
Testing performed, if any: None so far, will run regular tests
Test should be identical. FATES tests should only be different due to field list.