Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix albgrd_col value in SurfaceAlbedoType #1810

Merged
merged 1 commit into from
Nov 20, 2022

Conversation

ka7eh
Copy link
Contributor

@ka7eh ka7eh commented Jul 15, 2022

Description of changes

Fix value of albgrd_col in SurfaceAlbefdoType.F90.
Previously, the wrong value (albgri_col) was being set in InitHistory.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #1788

Are answers expected to change (and if so in what way)? no

Any User Interface Changes (namelist or namelist defaults changes)? no

Testing performed, if any:

Just for testing, I activated ALBGRD in hist_addfld2d to output the var and tested for SMS_Ld1_PS.f09_g17.I2000Clm50BgcCru.cheyenne_gnu.clm-datm_bias_correct_cruv7.
The tests passed on cheyenne.

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let us know if you want to talk about next steps for the testing / tagging process.

Copy link
Contributor

@olyson olyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

@ekluzek ekluzek self-assigned this Oct 17, 2022
@ekluzek
Copy link
Collaborator

ekluzek commented Oct 17, 2022

Another one I'll bring in.

@ekluzek ekluzek merged commit b2d71ba into ESCOMP:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

albgrd_col not set to spval before call to hist_addfld2d
4 participants