Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate FATES to use the normal BGC call sequence #1959

Merged
merged 55 commits into from
Aug 16, 2023
Merged

migrate FATES to use the normal BGC call sequence #1959

merged 55 commits into from
Aug 16, 2023

Commits on Jan 27, 2023

  1. Mocked up the updated cbalance checking with fates

    @rgknox
    rgknox committed Jan 27, 2023
    Configuration menu
    Copy the full SHA
    ff2e756 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Incremental progress towareds converting fates-clm carbon accounting … 

    …to using native calls and not EDBGCMod.
    @rgknox
    rgknox committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    55f0af2 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. another incremental step towards having the native cn balancing and c… 

    …all sequence when fates is on
    @rgknox
    rgknox committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    789eb9c View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. more incremental fates-clm mass balance checking and pathway coupling… 

    … changes
    @rgknox
    rgknox committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    c506151 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Incremental progress towards getting fates to work with the C and N b… 

    …udget pathway
    @rgknox
    rgknox committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    f38d9a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Pass through of getting fates in the full BGC call sequence. This inc… 

    …remental version does pass C and N balance checks at the column level, but not the grid level (because of missing diagnostic data structures)
    @rgknox
    rgknox committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    2f1ec52 View commit details
    Browse the repository at this point in the history

  2. Added suppln to fates cases

    @rgknox
    rgknox committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    cb4f510 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2023

  1. added vertical profile code to the fates bgc call sequence

    @rgknox
    rgknox committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    782b894 View commit details
    Browse the repository at this point in the history

  2. minor changes ot clmbuildnamelist

    @rgknox
    rgknox committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    4772204 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Removed various if-clauses that prevented BGC calls and initializatio… 

    …ns from proceeding with FATES on
    @rgknox
    rgknox committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    12e6b11 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. FATES bgc work. Add use_fates_bgc, cleaned out some use_fates filteri… 

    …ng, and added N deposition with FATES
    @rgknox
    rgknox committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    5539289 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into clmfates-cbalance

    @rgknox
    rgknox committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    0248331 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. updated fates external and the default parameter file

    @rgknox
    rgknox committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    8e638d4 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. moved the use_fates broadcast earlier in the control process

    @rgknox
    rgknox committed Mar 14, 2023
    Configuration menu
    Copy the full SHA
    4bdfea6 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Fixes to CN wood products restart w/ fates on

    @rgknox
    rgknox committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    f4092b3 View commit details
    Browse the repository at this point in the history

  2. cleaning up clm-fates bgc pr

    @rgknox
    rgknox committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    873883c View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2023

  1. cleanup of fates-bgc coupling

    @rgknox
    rgknox committed Mar 16, 2023
    Configuration menu
    Copy the full SHA
    79a77d6 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. FATES in the normal bgc call sequence, addressing reviewer comments

    @rgknox
    rgknox committed May 25, 2023
    Configuration menu
    Copy the full SHA
    ff923e1 View commit details
    Browse the repository at this point in the history

  2. Part-way through re-name-spacing the soilc and soilp filters for BGC

    @rgknox
    rgknox committed May 25, 2023
    Configuration menu
    Copy the full SHA
    158b182 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2023

  1. Updates to the build-namelist

    @rgknox
    rgknox committed May 26, 2023
    Configuration menu
    Copy the full SHA
    82d9b57 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. Reverting namelist defaults related to NDEP, we were getting ahead of… 

    … ourselves with fates n-cycling
    @rgknox
    rgknox committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1d3e8d0 View commit details
    Browse the repository at this point in the history

  2. merge resolution, mostly conflicts with Gross Unrepresented Landuse t… 

    …ransition work"
    @rgknox
    rgknox committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    c9b6ce9 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2023

  1. Fixes to build

    @rgknox
    rgknox committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    7fa071d View commit details
    Browse the repository at this point in the history

  2. Reverted use_cn filter on ndep namelist settings

    @rgknox
    rgknox committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    6959556 View commit details
    Browse the repository at this point in the history

  3. preserving b4b on nitrogen variables by referting a filter to allc

    @rgknox
    rgknox committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    27e28ab View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Updates to the fates-clm bgc call sequence, to preserve b4b behavior … 

    …in non-fates
    @rgknox
    rgknox committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    0f2d990 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. various fixes for fates bgc

    @rgknox
    rgknox committed Jun 14, 2023
    Configuration menu
    Copy the full SHA
    0676ac2 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. reverted call order on readfirenml

    @rgknox
    rgknox committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    868e8c2 View commit details
    Browse the repository at this point in the history

  2. Update default scope of cn_products_type procedures

    @rgknox
    rgknox committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    080cd5b View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2023

  1. update to the span of columns that carbon summary variables are calcu… 

    …lated, for b4b
    @rgknox
    rgknox committed Jul 4, 2023
    Configuration menu
    Copy the full SHA
    a4e690b View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Fixes to zeroing carbon and nitrogen summary variables

    @rgknox
    rgknox committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    40e7600 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. merge resolution on fates bgc call sequence and dev 130

    @rgknox
    rgknox committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    f452386 View commit details
    Browse the repository at this point in the history

  2. forgot to remove conflict tags

    @rgknox
    rgknox committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    3a8fb5c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Return this to what it was before the FATES addition should come later

    @ekluzek
    ekluzek committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    27f336d View commit details
    Browse the repository at this point in the history

  2. Check that with FATES on neither LUNA nor FUN can be on

    @ekluzek
    ekluzek committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    132f4eb View commit details
    Browse the repository at this point in the history

  3. Explicitly make sure you can not turn LUNA on with FATES, and add a u… 

    …se_luna setting for FATES with clm4_5 that was missing
    @ekluzek
    ekluzek committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d4261c8 View commit details
    Browse the repository at this point in the history

  4. Add a test that FATES with suplemental nitrogen on is NOT allowed, th… 

    …is test fails because that isn't in yet
    @ekluzek
    ekluzek committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    d2306c5 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Add error check for suplnitro for FATES

    @ekluzek
    ekluzek committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    739cf7c View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. resolving reviewer requests for clmfate-cbalance

    @rgknox
    rgknox committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    d4ed2f6 View commit details
    Browse the repository at this point in the history

  2. removed fates columns from the nocrop filter

    @rgknox
    rgknox committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    9dac206 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Added calls to set the litter source on restart for fates

    @rgknox
    rgknox committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    6f3a2f1 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2023

  1. Updates to nfixing during fates run

    @rgknox
    rgknox committed Jul 27, 2023
    Configuration menu
    Copy the full SHA
    dbac92c View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2023

  1. Moved a call to update a call to fates litter fluxes to be immediatel… 

    …y before we fill the decomp source-sink pools
    @rgknox
    rgknox committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    7c920c6 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. conflict resolutions between dev133 and clmfates-bgc

    @rgknox
    rgknox committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    e305a29 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2023

  1. Provisions to satisfy nag compiler, cnveg datastructures on now alloc… 

    …ated with 1 index 0 through 0 when fate_bgc is on, to avoid null pointers on associates
    Ryan Knox committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    907ca1a View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Update to clm-fates-bgc zero-allocating instead of not allocating cnv… 

    …eg arrays
    Ryan Knox committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    eaea030 View commit details
    Browse the repository at this point in the history

  2. Update fates external pointer to the fates bgc call sequence tag

    @rgknox
    rgknox committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    6925f8c View commit details
    Browse the repository at this point in the history

  3. update changelog

    @rgknox
    rgknox committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    1ccf0d9 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. Run through black, fix ESCOMP#2112

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8056ae6 View commit details
    Browse the repository at this point in the history

  2. Add black commit to git blame ignore file

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    c05ce88 View commit details
    Browse the repository at this point in the history

  3. Add list of source files and directories to the github action

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    76f1310 View commit details
    Browse the repository at this point in the history

  4. Try it with a one line list with square brackets

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    89ad049 View commit details
    Browse the repository at this point in the history

  5. Add actions for each source 

    Lists didn't work on the src: field, so add a complete action for each.
    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    44c696e View commit details
    Browse the repository at this point in the history

  6. Needs a dot in front of the directory, so doesn't do an absolute path

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    bab1735 View commit details
    Browse the repository at this point in the history

  7. Update Change files

    @ekluzek
    ekluzek committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5765f94 View commit details
    Browse the repository at this point in the history