Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some PE layouts on Derecho #2429

Merged
merged 5 commits into from
Mar 21, 2024
Merged

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Mar 20, 2024

Description of changes

Update PE layouts based on the Zender source PR #1967 and the ctsm5.2 branch #2372.
Changes: hcru, mpasa*, mpasa15, 4x5, ne16 and ne30 PE layouts on Derecho.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Some work on #2244

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Testing performed, if any: will run regular testing, but just Derecho
Also run ctsm_sci, and cesm3_dev
Also test:
hcru, mpasa480, mpasa15, ne30, and ne16 on Derecho, so the following...

ERP_D_Ln9.ne30pg3_t232.IHistClm51BgcCrop.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne16pg3_ne16pg3_mg17.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.mpasa480_mpasa480.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.mpasa15_mpasa15.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D.hcru_hcru_mt13.IHistClm51BgcCrop.derecho_intel.clm-default

@ekluzek ekluzek added the enhancement new capability or improved behavior of existing capability label Mar 20, 2024
@ekluzek ekluzek self-assigned this Mar 20, 2024
mpasa tests gave error about
duplicate PE layouts for them.
So explicitly set them.
@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2024

These tests pass on Derecho:

ERP_D_Ln9.ne30pg3_t232.IHistClm51BgcCrop.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.mpasa120_mpasa120.I1850Clm51Sp.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.mpasa480_mpasa480.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne0ARCTICGRISne30x8_ne0ARCTICGRISne30x8_mt12.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne0ARCTICne30x4_ne0ARCTICne30x4_mt12.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne0CONUSne30x8_ne0CONUSne30x8_mt12.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne120pg3_t13.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode
SMS_D_Ln9.ne16pg3_ne16pg3_mg17.I1850Clm51Bgc.derecho_intel.clm-clm51cam6LndTuningMode

The hcru test needs a dataset. And mpas60 and mpas15 had issues with init_interp. This should be resolved on the ctsm5.2 branch. So I'll ignore for now.

Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek I am interested in understanding the reasoning behind the choice of these numbers. Other than that, I approve.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 20, 2024

cesm3_dev and ctsm_sci testlists pass other than:

RXCROPMATURITY_Lm61.f09_g17.IHistClm50BgcCrop.derecho_intel.clm-cropMonthOutput
SSP_Ld4.f09_g17.I1850Clm50BgcCrop.derecho_intel.clm-ciso_rtmColdSSP

Which I think must be an issue in the base version. And I will check...

@ekluzek
Copy link
Collaborator Author

ekluzek commented Mar 21, 2024

aux_clm testing passed as expected on Derecho. So merging.

@ekluzek ekluzek merged commit d2dea27 into ESCOMP:b4b-dev Mar 21, 2024
2 checks passed
@ekluzek ekluzek deleted the pelayoutsupdate branch March 21, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability
Development

Successfully merging this pull request may close these issues.

2 participants