Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTSM5.2 1979 fsurdat and 1979-2026 landuse ne0np4 files #2490

Merged
merged 12 commits into from
May 9, 2024

Conversation

slevis-lmwg
Copy link
Contributor

Description of changes

Generate files and add infrastructure for them as explained below.

Specific notes

Contributors other than yourself, if any:
@ekluzek

CTSM Issues Fixed (include github issue #):
Fixes #2487

Are answers expected to change (and if so in what way)?
No

Any User Interface Changes (namelist or namelist defaults changes)?
Also listed in the issue #2487:
Adding 3 fsurdat and 3 landuse files to namelist defaults.
Adding testing for these to the ctsm_sci test-suite.
Adding these to mksurfdata_esmf so that they will be generated with make all.

Testing performed, if any:
Planned testing is listed in the issue #2487.

@slevis-lmwg slevis-lmwg self-assigned this Apr 26, 2024
@slevis-lmwg slevis-lmwg added enhancement new capability or improved behavior of existing capability testing additions or changes to tests PR status: work in progress bfb bit-for-bit priority: Immediate Highest priority, something that was unexpected labels Apr 26, 2024
@ekluzek ekluzek self-requested a review April 26, 2024 16:35
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 26, 2024

@slevis-lmwg you could rebase this to b4b-dev as the timeline for this one could be in cesm2_3_beta17 or in cesm2_3_beta18. But, up to you...

@ekluzek ekluzek removed the priority: Immediate Highest priority, something that was unexpected label Apr 26, 2024
@ekluzek ekluzek added this to the cesm2_3_beta18 milestone Apr 26, 2024
@ekluzek
Copy link
Collaborator

ekluzek commented Apr 30, 2024

This will likely come in with cesm2_3_beta17, but in CSEG we decided it coming in with cesm2_3_beta18 (before May 10th) is OK.

Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked it over and finished the questions that I needed to provide an answer for. There are some changes needed.

Other than that it looks great. Thanks for getting this together quickly. I'm changing this out of draft mode.

I'll learn in the CSEG meeting if we want this in for beta17 or not, and let you know...

cime_config/config_component.xml Outdated Show resolved Hide resolved
cime_config/config_component.xml Outdated Show resolved Hide resolved
cime_config/testdefs/testlist_clm.xml Outdated Show resolved Hide resolved
cime_config/testdefs/testlist_clm.xml Outdated Show resolved Hide resolved
cime_config/testdefs/testlist_clm.xml Outdated Show resolved Hide resolved
@ekluzek ekluzek marked this pull request as ready for review May 7, 2024 18:50
@slevis-lmwg slevis-lmwg added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete and removed PR status: work in progress labels May 8, 2024
@slevis-lmwg slevis-lmwg merged commit 7cf411a into ESCOMP:master May 9, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the vr_grid_updates branch May 9, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete testing additions or changes to tests
Projects
Status: Done (non release/external)
Status: Done
Development

Successfully merging this pull request may close these issues.

Add landuse.timeseries files for 1979-2026 for the three VR grids (CONUS, ARCTIC, ARCTICGRIS).
3 participants