-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing prescribed N and P uptake to 1 in the FATES PRT2 test #2624
Conversation
Per conversation with @rgknox, we're planning on using this to also include the default parameter file update coming with NGEET/fates#1206. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice and small and tidy, looks great. Nice, use of the autogeneration of FATES parameter files.
Per discussions with @rgknox, we're planning on coordinating this with an default parameter file update that will encompass NGEET/fates#1136 and NGEET/fates#1206. |
testing underway: |
Results on derecho from ./cs.status.fails, removing unexpected passes and expected fails. UPDATE: The two tests that fail are due to a bug-fix in the output variable FATES_TRANSITION_MATRIX_LULU , and are expected.
Tests on izumi are nominal |
Description of changes
We want to modify the default fates parameter file so that N and P uptake flux is not prescribed if the model is cycling N and P. Having this prescribed uptake active has confused users who are new to exploring N and P cycling. However, FATES needs prescribed N and P if it is coupling with a land model that is not N or P ready for FATES (such as CLM, which is only half coupled right now). This set of changes makes it so that the PRT2 test is forced to have prescribed N and P uptake in FATES.
Specific notes
Contributors other than yourself, if any:
@jenniferholm
CTSM Issues Fixed (include github issue #): none
Are answers expected to change (and if so in what way)? no, b4b all the way
Any User Interface Changes (namelist or namelist defaults changes)? not really
Does this create a need to change or add documentation? Did you do so? no
Testing performed, if any:
Tests OK, see below.