-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always check finidat_interp_dest.status #2679
Always check finidat_interp_dest.status #2679
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good @samsrabin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always good to move a simple thing into a subroutine that is then more modular and could allow a unit test to do be done.
If I understand the core change -- it's that the status is always going to be checked instead of only some of the time. Is that the right characterization @samsrabin? That also sounds like a good thing to do, and a nice usability improvement. I do think these files continue to sometimes cause problems for people and this should help.
Thanks, both! Adding the stalled label because testing will have to wait for Derecho to return to service. And @ekluzek, yes, it's just adding an extra check (the one in |
True differences were found in 4 tests so far:
The FATES ones were all in
But I think that's basically infinity, so I'm not worried about it. Waiting for a few more tests to finish. |
The LULU failures have an open issue that Greg is working on. |
Description of changes
Adds a check for the existence of the
finidat_interp_dest.status
file.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
aux_clm
testing; waiting for initial PR approval.