-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fang summer '24 PR 1.1] Fix bugs and develop crop fire modeling #2684
Conversation
Includes new fire_method li2024gswpfrc.
In the CNFireLi2024Mod.F90, (1) fixed the bug described in ESCOMP#2566 to avoid incorrect accumulation of baf_crop and ensure that crop fires do not occur during the crop growing season; (2) confined crop fires to periods after harvest and before planting when crop module is active; (3) removed the dependency of baf_crop on fuel availability; (4) improved the modeling of the influence of socio-economic factors on crop burned area; (5) recalibrated the cropfire_a1 constant based on GFED5 crop burned area; (6) modify the declaration of CNFireArea in these F90 files to include the variable crop_inst, declare the variable crop_inst, and import and utilize crop_type from the module CropType. In addition, the modules CNDriverMod.F90, CNFireLi2014Mod.F90, CNFireLi2016Mod.F90, CNFireLi2021Mod.F90, CNFireNoFireMod.F90, FATESFireBase.F90, and FireMethodType.F90 include the subroutine CNFireArea. (6) is implemented in these modules. (Original commit by Fang Li, lifang@mail.iap.ac.cn.)
(Original commit by Fang Li, lifang@mail.iap.ac.cn.)
Up-to-date with ctsm5.2.015.
|
Oh, also:
|
I will start with what I know: Regarding test coverage, I could form an opinion if we discussed it, or I'm happy to let others weigh in. |
@slevis-lmwg I think the test coverage is fine for now. We can maybe add more later, perhaps when I make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@samsrabin thank you for working on this.
|
(Supersedes #2576, which I'm replacing so as to put these changes in a new fire module rather than changing
CNFireLi2021Mod.F90
.)Description of changes
Copied CNFireLi2021Mod.F90 to new CNFireLi2024Mod.F90. In the latter (original description by @lifang0209 in #2576):
The new fire module is not on by default; it requires setting
fire_method
toli2024gswpfrc
. This will become the default only after #2615 is merged.Specific notes
Contributors other than yourself, if any: @lifang0209
CTSM Issues Fixed (include github issue #):
Are answers expected to change (and if so in what way)? Only when manually setting
fire_method
toli2024gswpfrc
. Global burned area increases about 30 Mha/yr. Crop fires only occur after harvest and before planting.Any User Interface Changes (namelist or namelist defaults changes)? Yes:
fire_method
li2024gswpfrc
.Does this create a need to change or add documentation? Did you do so? New documentation will be needed when
li2024gswpfrc
becomes the default, but not yet.Testing performed, if any:
li2024gswpfrc
aux_clm
test suite passes bit-for-bit, since by defaultli2024gswpfrc
is off.