-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPE change to sa_leaf in CanopyFluxesMod.F90 #2788
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wwieder Removing my assignment, as with the change to our queue order I no longer care when this comes in ;-) |
This comment was marked as resolved.
This comment was marked as resolved.
Starting aux_clm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think "larger than roundoff/same climate" is adequate, and maybe not put "X" in the checkboxes? Unless "significant" means the same thing as "larger than rounoff/same climate". I interpret significant as meaning different climate, which is not what I think we have here. Also, I suggest maybe include a direct link to the diagnostics, instead of indirectly through the issue?
I have preemptively updated the ChangeLog with aux_clm results. |
Description of changes
Add change to sa_leaf that was in PPE branch but is not on master
Specific notes
Contributors other than yourself, if any: @olyson
CTSM Issues Fixed (include github issue #):
Fixes #2777
Are answers expected to change (and if so in what way)? Yes. See #2777 for results.
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? Yes. No.
Testing performed, if any:
No test suite testing thus far.