Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile #2834

Conversation

slevis-lmwg
Copy link
Contributor

@slevis-lmwg slevis-lmwg commented Oct 16, 2024

Description of changes

Same as title.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #2791
Completes most of #2810 (not sure whether I am adding the test in FATES)

Are answers expected to change (and if so in what way)?
No.

Any User Interface Changes (namelist or namelist defaults changes)?
New fsurdat/landuse files added to the defaults.

Does this create a need to change or add documentation? Did you do so?
No.

Testing performed, if any:
On derecho
PASS Tested the addition of the new fsurdat/landuse files to the Makefile with make global-hist-1850-f19
PASS Tested the addition of the new fsurdat/landuse files to the Makefile with make global-hist-1850-f45
PASS ./build-namelist_test.pl
PASS python testing
PASS clm_pymods

@slevis-lmwg slevis-lmwg self-assigned this Oct 16, 2024
@slevis-lmwg slevis-lmwg added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete bfb bit-for-bit size: small labels Oct 16, 2024
@slevis-lmwg
Copy link
Contributor Author

Rebase to cesm3_0_beta04_changes.

@slevis-lmwg slevis-lmwg changed the base branch from master to cesm3_0_beta04_changes October 23, 2024 21:09
@slevis-lmwg slevis-lmwg marked this pull request as ready for review October 24, 2024 22:53
@slevis-lmwg slevis-lmwg removed the PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete label Oct 24, 2024
@slevis-lmwg
Copy link
Contributor Author

Adding the scope of #2810 to this PR

@slevis-lmwg slevis-lmwg changed the title f19 16pft fsurdat/landuse files to namelist_defaults_ctsm.xml and Makefile f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile Oct 25, 2024
@slevis-lmwg slevis-lmwg added PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete PR status: awaiting review Work on this PR is paused while waiting for review. labels Oct 25, 2024
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@slevis-lmwg slevis-lmwg removed the PR status: awaiting review Work on this PR is paused while waiting for review. label Oct 25, 2024
@slevis-lmwg slevis-lmwg merged commit c35b64e into ESCOMP:cesm3_0_beta04_changes Oct 25, 2024
2 checks passed
@slevis-lmwg slevis-lmwg deleted the f19_16pft_to_defaults_and_makefile branch October 25, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit PR status: ready PR: this is ready to merge in, with all tests satisfactory and reviews complete size: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add f19 16pft 1850 and Hist to list of surface dataset resolutions (for the PPE work)
2 participants