-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile #2834
Merged
slevis-lmwg
merged 11 commits into
ESCOMP:cesm3_0_beta04_changes
from
slevis-lmwg:f19_16pft_to_defaults_and_makefile
Oct 25, 2024
Merged
f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile #2834
slevis-lmwg
merged 11 commits into
ESCOMP:cesm3_0_beta04_changes
from
slevis-lmwg:f19_16pft_to_defaults_and_makefile
Oct 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slevis-lmwg
added
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
bfb
bit-for-bit
size: small
labels
Oct 16, 2024
This was referenced Oct 16, 2024
Rebase to cesm3_0_beta04_changes. |
slevis-lmwg
commented
Oct 21, 2024
4 tasks
…akefile' into f19_16pft_to_defaults_and_makefile slevis resolved conflicts: bld/namelist_files/namelist_defaults_ctsm.xml
slevis-lmwg
removed
the
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
label
Oct 24, 2024
Adding the scope of #2810 to this PR |
slevis-lmwg
changed the title
f19 16pft fsurdat/landuse files to namelist_defaults_ctsm.xml and Makefile
f19 + f45 16pft fsurdat/landuse files to namelist_defaults_ctsm + Makefile
Oct 25, 2024
slevis-lmwg
added
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
PR status: awaiting review
Work on this PR is paused while waiting for review.
labels
Oct 25, 2024
ekluzek
approved these changes
Oct 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
slevis-lmwg
removed
the
PR status: awaiting review
Work on this PR is paused while waiting for review.
label
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bfb
bit-for-bit
PR status: ready
PR: this is ready to merge in, with all tests satisfactory and reviews complete
size: small
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Same as title.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #2791
Completes most of #2810 (not sure whether I am adding the test in FATES)
Are answers expected to change (and if so in what way)?
No.
Any User Interface Changes (namelist or namelist defaults changes)?
New fsurdat/landuse files added to the defaults.
Does this create a need to change or add documentation? Did you do so?
No.
Testing performed, if any:
On derecho
PASS Tested the addition of the new fsurdat/landuse files to the Makefile with
make global-hist-1850-f19
PASS Tested the addition of the new fsurdat/landuse files to the Makefile with
make global-hist-1850-f45
PASS ./build-namelist_test.pl
PASS python testing
PASS clm_pymods