Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update temperature cost function for symbiotic Nfix in FUN #2869

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

wwieder
Copy link
Contributor

@wwieder wwieder commented Nov 7, 2024

Description of changes

Updates temperature cost function of Nfix using lab measurements from Bytnerowicz et al. (2022), see Supplementary Table 3.

Specific notes

Replaces the Houlton temperature cost function that's currently used in CNFUN.

  • requires updated parameter file with min, optimum, and max temperatures for tropical and extra-tropical PFTs. /glade/work/wwieder/modified_inputs/ctsm60_params_nfix.c241101.nc

Updated temperature function (below in blue) compared to the default temperature function from Houlton et al (orange) to calculate C costs of N fix in FUN (second figure).

image
image

Contributors other than yourself, if any:
Tom Bytnerowicz, @tbytnero, t.bytnerowicz@ufl.edu

CTSM Issues Fixed (include github issue #):
None

Are answers expected to change (and if so in what way)?
Reduces temperate N fix and vegetation C pools. Also modifies temporal changes over historical and SSP scenarios.

Diagnostics from CRU-JRA forced runs at f19 posted here

Issue on LMWG-dev linked here
Discussion on Nfix started on LMWG-dev

Any User Interface Changes (namelist or namelist defaults changes)?
TODO add namelist option for Bytnerowicz vs. Houlton Nfix cost function

Does this create a need to change or add documentation? Did you do so?
Needs to be added to documentation, not currently done

Testing performed, if any:
Ran scientific tests in point simulations (CLM5.1 code base) and global 2 degree spinup, historical and SSP2-4.5 case.

@wwieder wwieder added enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science labels Nov 7, 2024
@linniahawkins
Copy link

Given that the new temperature cost function will be included in the ctsm6 release, we will need to re-run the One-at-a-time parameter ensemble. To do so, we will need a tag that is greater than ctsm5.3.010 with this new cost function added.

We will also need a parameter file that is compatible with ctsm5.3.010 (ctsm60_params.c241017.nc) and adds the three new parameters from this function.

I'll also need a restart from the 2-degree spinup Will already ran.

@wwieder
Copy link
Contributor Author

wwieder commented Nov 15, 2024

@linniahawkins and @ekluzek I've:

  • Removed unnecessary usermods from this PR
  • Updated to the latest dev tag, 012.
  • Added new parameters for Tom's nfix function to the default parameter file ctsm60_params.c241017.nc. This can be used / seen here paramfile = '/glade/work/wwieder/modified_inputs/ctsm60_params.c241114.nc'
  • Created, built, & ran a case to test that things still work /glade/work/wwieder/ctsm5.3.0/ctsm5.3.012_f19_nfix_test
  • Initial condition files for f19 are here
finidat = '/glade/derecho/scratch/wwieder/archive/ctsm530_f19_nfix_pSASU/rest/0161-01-01-00000/ctsm530_f19_nfix_pSASU.clm2.r.0161-01-01-00000.nc'

Next steps would be to:

  1. Erik creates a branch tag for Linnia
  • Will / @olyson checks 1850 survivability in the default f19_PPE case and the f19_nfix cases
  1. Will / Erik adds a namelist option for the nfix_temperature_method = 1 (Houlton function from CLM5)
  2. Bring PR onto b4b-dev
  3. Answer changing tag to master, setting nfix_temperature_method =2 (Tom's function)

Let me know what you think of this plan and what I've missed.

@wwieder
Copy link
Contributor Author

wwieder commented Nov 15, 2024

Doesn't seem like the NFIX changes make a big impact on arctic survival. Dead grids (max ELAI < 0.1) for PPE and NFix cases are on the left and center. max LAIs from the PPE where Nfix case is dead are on the right.

image

@ekluzek ekluzek added this to the cesm3_0_beta06 milestone Nov 19, 2024
@ekluzek ekluzek self-assigned this Nov 19, 2024
…nd update ctsm60 file so that it is based on the previous one with the nfix fields just added to the end
@ekluzek
Copy link
Collaborator

ekluzek commented Nov 20, 2024

Testing on Derecho and Izumi are as expected other than the following which fail, because they need update parameter files

ERS_Ld3.f10_f10_mg37.I2000Clm60Bgc.derecho_intel.clm-ciso_cwd_hr (RUN)
ERS_Ld3.f10_f10_mg37.I2000Clm60Bgc.derecho_intel.clm-ciso_cwd_hr--clm-matrixcnOn (RUN)
SMS_Lm1.f10_f10_mg37.I1850Clm60Bgc.derecho_intel.clm-clm60_monthly_matrixcn_soilCN30 (RUN)

@ekluzek
Copy link
Collaborator

ekluzek commented Nov 20, 2024

Branch tag made: branch_tags/BNF_v2.n01_ctsm5.3.012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants