Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing cleanup from the cesm3_0_beta03/04 "chill" tags for cesm3_0_beta05 #2888

Open
wants to merge 112 commits into
base: master
Choose a base branch
from

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 18, 2024

Description of changes

Fix a list of issues mostly for testing that came in with the cesm3_0_beta03 and cesm3_0_beta04 tags for the science "chill" deadline bringing in the baseline science capabilities needed for the cesm3_0 release.

List of things:

  • New polarcap grid
  • Fix use_init_interp for several resolutions that had
  • Remove clm5_1 physics option
  • Newly needed surface datasets added to auto build in Makefile for mksurfdata_esmf
  • Fix several individual tests that were failing
  • Update to submodules to ones roughly based on cesm3_0_beta04

Specific notes

Contributors other than yourself, if any: @slevis-lmwg @adamrher

CTSM Issues Fixed (include github issue #): The individual PR's to this branch have the list of things resolved.

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: will do regular testing

adamrher and others added 30 commits August 20, 2024 15:25
Reduce outputs from matrixcnOn tests
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability testing additions or changes to tests bfb bit-for-bit labels Nov 18, 2024
@ekluzek ekluzek added this to the cesm3_0_beta05 milestone Nov 18, 2024
@ekluzek ekluzek self-assigned this Nov 18, 2024
Copy link
Collaborator Author

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw one thing that I thought needed at least some comments to explain.

@@ -678,6 +678,11 @@ sub setup_cmdl_chk_res {
}
}

sub begins_with
{
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is making a bunch of perl assumptions in regard to syntax that are unintuitive, so at least need some comments to explain.

…r compsets, make sure yearly ER tests have at least 3 years, or done in days
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see all these cumulative changes coming in! Thank you, Erik.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 21, 2024

There's a few unexpected fails in the Derecho/Izumi fates testlist:

ERS_D_Ld30.f45_f45_mg37.I2000Clm50FatesCruRsGs.derecho_intel.clm-FatesColdLandUse (SETUP) EXPECTED (SHAREDLIB_BUILD)
ERS_Lm12.1x1_brazil.I2000Clm50FatesCruRsGs.derecho_intel.clm-FatesFireLightningPopDens (NLCOMP RUN)
ERS_D_Ld30.f45_f45_mg37.I2000Clm50FatesCruRsGs.izumi_nag.clm-FatesColdLandUse (SETUP) EXPECTED (SHAREDLIB_BUILD)
ERS_D_Ld30.f45_f45_mg37.I2000Clm50FatesCruRsGs.izumi_nag.clm-FatesColdPRT2 (CREATE_NEWCASE) EXPECTED (RUN)
ERS_D_Ld5.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_nag.clm-FatesColdHydro (CREATE_NEWCASE)
SMS_Lm3_D_Mmpi-serial.1x1_brazil.I2000Clm50FatesCruRsGs.izumi_nag.clm-FatesColdHydro (CREATE_NEWCASE)

…sing a transient compset longname, and adjusting some things in the test-mod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability testing additions or changes to tests
Projects
Status: In progress - master/b4b-dev
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants