Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge b4bdev 20241125 #2893

Merged
merged 24 commits into from
Nov 26, 2024
Merged

Merge b4bdev 20241125 #2893

merged 24 commits into from
Nov 26, 2024

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Nov 25, 2024

Description of changes

  • Update git-fleximod
  • Fix equation number in tech note
  • Implement urbanl and urbanc coszen filters
  • Make ALBGRD and ALBGRI active by default
  • Some adjustments to control pylint for the crop calendar python code
  • Run_sys_tests: Print test list in --verbose/--debug

Specific notes

Contributors other than yourself, if any: @jedwards4b @olyson @adrifoster @seleneonowe @samsrabin

CTSM Issues Fixed (include github issue #):
Fixes #17 albgrd and albgri history fields depend on decomposition, for urban points
Fixes #747 In UrbanAlbedo: Create a filter for coszen>0 and operate over that

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)?

  • New options in run_sys_tests
  • ALBGRD/ALBGRI now on h0 history file by default

Does this create a need to change or add documentation? Did you do so? No No

Testing performed, if any: will run regular testing
So far ran PFUNIT tests, build-namelist tests, and python tests, running aux_clm on Derecho

jedwards4b and others added 23 commits September 25, 2024 08:35
git-subtree-dir: .lib/git-fleximod
git-subtree-split: 02e859950fd79064ad5b64565ce1073bea5d3ffa
A link that should be to an equation for leaf boundary layer resistance was instead pointing to one for canopy air temperature.
Remove num_solar and implement coszen filters in UrbanAlbedoMod.F90
run_sys_tests: Print test list in --verbose/--debug
Fix numbering error in CLM50_Tech_Note_Fluxes.rst
50bd54c63 Bump to 0.9.3
1e0c40a46 Merge pull request ESCOMP#66 from ESMCI/poetry_and_test_update
135770709 strip strip
e7f9a261c fix issue 65
b1568e724 update poetry certifi version and update tests failing due to mpi-serial update

git-subtree-dir: .lib/git-fleximod
git-subtree-split: 50bd54c63e38c52e0bfc4a1d6bc6cb0eea6cf645
@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability code health improving internal code structure to make easier to maintain (sustainability) testing additions or changes to tests bfb bit-for-bit priority: Immediate Highest priority, something that was unexpected usability Improve or clarify user-facing options labels Nov 25, 2024
@ekluzek ekluzek added this to the cesm3_0_beta05 milestone Nov 25, 2024
@ekluzek ekluzek self-assigned this Nov 25, 2024
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock Erik.

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 26, 2024

Testing on Derecho and Izumi is passing as expected. I'm still seeing the mpi-serial nag tests failing at runtime as we did before, even though I had seen it working for cases yesterday. So I'm moving forward with the tag.

@ekluzek ekluzek merged commit 2307c15 into ESCOMP:master Nov 26, 2024
2 checks passed
@ekluzek ekluzek deleted the merge-b4bdev-20241125 branch November 26, 2024 22:31
@ekluzek ekluzek restored the merge-b4bdev-20241125 branch November 26, 2024 22:33
@ekluzek ekluzek deleted the merge-b4bdev-20241125 branch November 26, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit code health improving internal code structure to make easier to maintain (sustainability) enhancement new capability or improved behavior of existing capability priority: Immediate Highest priority, something that was unexpected testing additions or changes to tests usability Improve or clarify user-facing options
Projects
Status: Done
7 participants