Skip to content

Commit

Permalink
Add kessler_test Test SDF for FPHYStest to split off from FKESSLER te…
Browse files Browse the repository at this point in the history
…st (#204)

Originator(s): jimmielin

Description (include issue title and the keyword ['closes', 'fixes',
'resolves'] and issue number):

The FPHYStest test for Kessler in SIMA right now uses the same
`suite_kessler.xml` as FKESSLER, which means it includes
`physics_after_coupler` and other `check_energy` schemes we do not want
to include in the FPHYStest test which should only be testing
`kessler_tend`.

This PR includes a new `suite_kessler_test.xml` that removes all the
other schemes from the SDF and keeps only what we want to test, and
consistent with how the snapshots are taken in CAM:

```fortran
      if (trim(cam_take_snapshot_before) == "kessler_tend") then
         call cam_snapshot_all_outfld(cam_snapshot_before_num, state, tend, cam_in, cam_out, pbuf)
      end if

      call kessler_tend(state, ptend, ztodt, pbuf)
      if ( (trim(cam_take_snapshot_after) == "kessler_tend") .and.            &
           (trim(cam_take_snapshot_before) == trim(cam_take_snapshot_after))) then
         call cam_snapshot_ptend_outfld(ptend, lchnk)
      end if
      call physics_update(state, ptend, ztodt, tend)

      if (trim(cam_take_snapshot_after) == "kessler_tend") then
         call cam_snapshot_all_outfld(cam_snapshot_after_num, state, tend, cam_in, cam_out, pbuf)
      end if
```

List all namelist files that were added or changed: N/A

List all files eliminated and why: N/A

List all files added and what they do:
```
A       test/test_suites/suite_kessler_test.xml
  - new kessler_test suite
```

List all existing files that have been modified, and describe the
changes:
(Helpful git command: `git diff --name-status
development...<your_branch_name>`)
N/A

List all automated tests that failed, as well as an explanation for why
they weren't fixed:
N/A

Is this an answer-changing PR? If so, is it a new physics package,
algorithm change, tuning change, etc?
Yes for FPHYStest kessler test

If yes to the above question, describe how this code was validated with
the new/modified features:
BFB when using this suite
  • Loading branch information
jimmielin authored Feb 14, 2025
1 parent c46e063 commit 252b500
Showing 1 changed file with 24 additions and 0 deletions.
24 changes: 24 additions & 0 deletions test/test_suites/suite_kessler_test.xml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
<?xml version="1.0" encoding="UTF-8"?>

<suite name="kessler_test" version="1.0">
<group name="physics_before_coupler">
<scheme>calc_exner</scheme>
<scheme>temp_to_potential_temp</scheme>
<scheme>calc_dry_air_ideal_gas_density</scheme>
<scheme>wet_to_dry_water_vapor</scheme>
<scheme>wet_to_dry_cloud_liquid_water</scheme>
<scheme>wet_to_dry_rain</scheme>
<scheme>kessler</scheme>
<scheme>potential_temp_to_temp</scheme>
<scheme>dry_to_wet_water_vapor</scheme>
<scheme>dry_to_wet_cloud_liquid_water</scheme>
<scheme>dry_to_wet_rain</scheme>
<scheme>kessler_update</scheme>
<scheme>qneg</scheme>
<scheme>geopotential_temp</scheme>

<!-- State diagnostics -->
<scheme>sima_state_diagnostics</scheme>
<scheme>kessler_diagnostics</scheme>
</group>
</suite>

0 comments on commit 252b500

Please sign in to comment.