Unit test infrastructure setup #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nusbaume
approved these changes
Nov 4, 2024
There was a problem hiding this comment.
Looks good to me! Just had a couple of questions.
Also, when you get the chance can you add some general instructions for how to add a new unit test to the official CAM-SIMA documentation? You can probably put it under the "Atmospheric_physics" section for now (but feel free to add it somewhere else if you think it makes more sense). Thanks!
jimmielin
approved these changes
Nov 6, 2024
peverwhee
reviewed
Nov 8, 2024
Added a README with a few instructions and pointer to the gh-docs page but just let me know if there's any other details you think we should add. |
peverwhee
approved these changes
Nov 11, 2024
jimmielin
added a commit
that referenced
this pull request
Nov 19, 2024
Tag name (The PR title should also include the tag name): `atmos_phys0_07_000` Originator(s): @jimmielin List all `development` PR URLs included in this PR and a short description of each: * #141 by @mattldawson @boulderdaze * #147 by @peverwhee * #144 by @mwaxmonsky * #151 by @mattldawson * #145 by @jimmielin List all test failures: N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originator(s): @mwaxmonsky
Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number): Sets up the basic infrastructure to start enabling unit testing. Addresses #82
Describe any changes made to the namelist: N/A
List all files eliminated and why: N/A
List all files added and what they do:
A .github/workflows/code-coverage.yaml
A test/unit-test/CMakeLists.txt
A test/unit-test/include/ccpp_kinds.F90
A test/unit-test/tests/CMakeLists.txt
A test/unit-test/tests/utilities/CMakeLists.txt
A test/unit-test/tests/utilities/test_state_converters.pf
List all existing files that have been modified, and describe the changes: N/A
(Helpful git command:
git diff --name-status development...<your_branch_name>)List any test failures: N/A
Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No