Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extraterrestrial flux in TUV-x prior to calculating rate constants #152

Merged
merged 16 commits into from
Nov 21, 2024

Conversation

boulderdaze
Copy link
Collaborator

@boulderdaze boulderdaze commented Nov 9, 2024

Originator(s): @boulderdaze

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Describe any changes made to the namelist: N/A

List all files eliminated and why:

D       test/musica/tuvx/configs/ts1_tsmlt.json

We have moved the MUSICA configuration to CAM-SIMA Chemistry Data repository

List all files added and what they do:

A       schemes/musica/tuvx/musica_ccpp_tuvx_extraterrestrial_flux.F90
A       test/musica/tuvx/test_tuvx_extraterrestrial_flux.F90
A       to_be_ccppized/ccpp_tuvx_utils.F90

List all existing files that have been modified, and describe the changes:

M       schemes/musica/micm/musica_ccpp_micm.F90
M       schemes/musica/musica_ccpp.F90
M       schemes/musica/musica_ccpp.meta
M       schemes/musica/tuvx/musica_ccpp_tuvx.F90
M       schemes/musica/tuvx/musica_ccpp_tuvx_surface_albedo.F90
M       schemes/musica/tuvx/musica_ccpp_tuvx_temperature.F90
M       schemes/musica/tuvx/musica_ccpp_tuvx_util.F90
M       schemes/musica/tuvx/musica_ccpp_tuvx_wavelength_grid.F90
M       test/CMakeLists.txt
M       test/docker/Dockerfile.musica
M       test/docker/Dockerfile.musica.no_install
M       test/musica/CMakeLists.txt
M       test/musica/test_musica_api.F90
M       test/musica/tuvx/CMakeLists.txt

List any test failures: N/A

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

@boulderdaze boulderdaze self-assigned this Nov 11, 2024
Copy link
Collaborator

@mattldawson mattldawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I don't have any questions or suggestions

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@boulderdaze boulderdaze merged commit d755e19 into development Nov 21, 2024
3 checks passed
@boulderdaze boulderdaze deleted the 97-update_et_flux branch November 21, 2024 17:01
jimmielin added a commit that referenced this pull request Dec 31, 2024
Tag name (The PR title should also include the tag name):
`atmos_phys0_07_001`
Originator(s): @jimmielin

List all `development` PR URLs included in this PR and a short
description of each:
* Update extraterrestrial flux in TUV-x prior to calculating rate constants #152 by @boulderdaze
* Simplify deallocation of multiple objects associated with the TUV-x #156 by @boulderdaze
* Fill in errmsg, errflg in check_energy schemes #160 by @jimmielin
* Validates the MUSICA meta data against the CCPP standard names #162 by @boulderdaze
* Add constituent tendency updater #111 by @peverwhee
* Add cloud optical calculations for use in TUV-x #167 by @mattldawson
* Add initialize_constituents scheme #149 by @peverwhee
* Add diagnostics to TJ2016 test schemes #170 by @peverwhee
* update "radians" to "rad" #173 by @peverwhee
* Solar zenith angle and Earth-Sun distance #171 by @mattldawson
* Update standard names for tropopause_find #140 by @jimmielin
* Update surface albedo units #181 by @mattldawson
* don't set water species property for species that air_composition handles #185 by @peverwhee

List all test failures: N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants