Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new constituent tendency updater in cam7 SDF #188

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

peverwhee
Copy link
Collaborator

@peverwhee peverwhee commented Jan 6, 2025

Originator(s): peverwhee

Summary (include the keyword ['closes', 'fixes', 'resolves'] and issue number):

Uses new constituent tendency updater scheme (apply_constituent_tendencies) instead of the temporary dry adiabatic adjustment updater (that no longer exists!)

closes #179

Describe any changes made to the namelist: N/A

List all files eliminated and why: N/A

List all files added and what they do:

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)

M suites/suite_cam7.xml

  • use apply_constituent_tendencies scheme

List any test failures: n/a

Is this a science-changing update? New physics package, algorithm change, tuning changes, etc? No

Copy link
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

I added a #179 before when running into the CAM7 suite issues - could you please note in the PR text that this closes #179 so it can be auto-closed? Thanks!

Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @peverwhee!

@peverwhee peverwhee changed the base branch from main to development January 8, 2025 17:20
@peverwhee peverwhee merged commit 74e905b into ESCOMP:development Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to update CAM7 suite SDF to use constituent tendency updater
3 participants