implement generic output name for routing method specific variables #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g., routedRunoff, volume
nmizukami
added
cesm-coupling
ekluzek
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
We talked about some changes that @nmizukami will change as he sees fit. But, approving so he doesn't have to have me reapprove. This is a very nice improvement that I'm glad to see come in.
…ing method specification in control file
…clude 0=sumUpstreamRunoff or not)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently routed runoff, volume, inflow history variable names add routing method abbreviation in front of variables (== routing specific name)
For example, if you run Muskingum Cunge method, routed runoff name is MCroutedRunoff. This name convention may be ok if users run multiple routing schemes at the same time to distinguish.
However, if users run only with one method, users may want to just use more generic names, routedRunoff, volume, or inflow etc.,
This PR enables this option. The default still uses routing specific name.
CESM-coupled run typically uses only one method, and for testing purpose, we want to use generic name to compare the history files among different versions and cases.
resolve #481