Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential Auth models #40

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rhysrevans3
Copy link
Collaborator

@rhysrevans3 rhysrevans3 commented Feb 12, 2025

My understanding of the transaction api's authroisation code is:

  • The authorizer collects information about the user and adds it to the request state.
  • The client then calls its authorize method which check the incoming payload against the generated authorisation state.

This pull request adds a pydantic model for the return of the authorizer. If the East and West authorizer middleware returns the same model it would allow us to use the same authorize method in the client.

Any objections to having a model for the return of the authorizer? Or to the structure or content of the model?

@sturoscy-personal
Copy link
Contributor

Apologies if I'm missing something, isn't this already taken care of by the RequesterData and Auth models? https://github.com/ESGF/esgf-playground-utils/blob/main/esgf_playground_utils/models/kafka.py#L90-L100

@sturoscy-personal
Copy link
Contributor

Perhaps a better question to ask is where would these models be used in the transaction api?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants