Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds reserved Zenodo 1.3.1 DOI before #243

Merged
merged 1 commit into from
May 1, 2023
Merged

adds reserved Zenodo 1.3.1 DOI before #243

merged 1 commit into from
May 1, 2023

Conversation

ashepherd
Copy link
Member

No description provided.

@ashepherd ashepherd self-assigned this Apr 27, 2023
@ashepherd ashepherd requested a review from njarboe April 27, 2023 20:03
Copy link
Collaborator

@njarboe njarboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but the Zenodo DOI is not active. Maybe that should be done first so the README does not have a broken link?

Copy link
Collaborator

@njarboe njarboe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need the merge to happen before you put the code on Zenodo or can you just use this branch for the Zenodo contribution pre-merge?

@ashepherd
Copy link
Member Author

yeah, the workflow is a a little odd, first we reserve a DOI at zenodo, and then i update all the places we mention the DOI, then I package that up as a ZIP file and deposit at Zenodo for the reserved DOI. That gets the Zenodo DOI into the archived pkg.

@njarboe
Copy link
Collaborator

njarboe commented May 1, 2023

Ok. So should I merge now even though the Zenodo link will be broken?

@ashepherd
Copy link
Member Author

Yeah, it's work once I publish the Zenodo versionafter putting the ZIP file in there

@njarboe njarboe merged commit d0204a4 into master May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants