Update the filenames for RRTMGP v1.7 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedwards4b
approved these changes
Feb 7, 2024
|
Thanks @jedwards4b . This change is only needed when people want to run RRTMGP on the GPU. If the CAM tag only focuses on the CPU result, I think they could bring in this change in a separate PR? @brian-eaton , what do you think? |
|
That's a good point, this change only affects nvhpc gpu users - ie @sjsprecious . |
|
That sounds OK to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RRTMGP will be brought into CAM as the new radiation scheme (ESCOMP/CAM#909).
Since the tag
v1.7, a few files containing the GPU directives have been renamed. Thus we need to update theDepends.nvhpcfile accordingly to apply the GPU flags correctly.