Skip to content

Commit

Permalink
Merge pull request #1610 from ESMCI/fischer/testreporter_fix
Browse files Browse the repository at this point in the history
Update testreporter and change hobart queue to medium.
Update testreporter.py to handle compare failures that were being missed.
Remove tagname from the testdb comments that were added to the GENERATE and
BASLINE lines in TestStatus.
Change the default queue on hobart from short to medium to handle tests that were
running a little long.

Test suite: scripts_regression_tests.pr, populated testdb for alpha06m
Test baseline:
Test namelist changes:
Test status: bit for bit,

Fixes #1555

User interface changes?:

Code review:jedwards
  • Loading branch information
jedwards4b authored May 25, 2017
2 parents a9cc09c + 83d6f74 commit 162ba85
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 3 deletions.
3 changes: 2 additions & 1 deletion config/cesm/machines/config_batch.xml
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,8 @@
<directive default="/bin/bash" > -S {{ shell }} </directive>
</directives>
<queues>
<queue walltimemax="02:00:00" jobmin="1" jobmax="192" default="true">short</queue>
<queue walltimemax="02:00:00" jobmin="1" jobmax="192" >short</queue>
<queue walltimemax="06:00:00" jobmin="1" jobmax="192" default="true">medium</queue>
<queue walltimemax="40:00:00" jobmin="1" jobmax="144" >long</queue>
</queues>
</batch_system>
Expand Down
22 changes: 20 additions & 2 deletions scripts/Tools/testreporter.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,13 +181,31 @@ def get_testreporter_xml(testroot, testid, tagname, testtype):
if line[0:4] == "FAIL":
test_status['COMMENT']+="Hybrid fail! "
break
if "COMPARE_base_multiinst" in line:
test_status['STATUS']=line[0:4]
if line[0:4] == "FAIL":
test_status['COMMENT']+="Multi instance fail! "
break
if "COMPARE_base_test" in line:
test_status['STATUS']=line[0:4]
if line[0:4] == "FAIL":
test_status['COMMENT']+="Base test fail! "
break
if "COMPARE_base_single_thread" in line:
test_status['STATUS']=line[0:4]
if line[0:4] == "FAIL":
test_status['COMMENT']+="Thread test fail! "
break

#
# Do not include time comments. Just a preference to have cleaner comments in the test database
#
try:
if 'time=' not in line:
test_status['COMMENT']+=line.split(' ',3)[3]+' '
if 'time=' not in line and 'GENERATE' not in line:
if 'BASELINE' not in line:
test_status['COMMENT']+=line.split(' ',3)[3]+' '
else:
test_status['COMMENT']+=line.split(' ',4)[4]+' '
except:
pass

Expand Down

0 comments on commit 162ba85

Please sign in to comment.