Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call to ESMF_initialize should allow for no PET logfiles #1245

Closed
gold2718 opened this issue Mar 14, 2017 · 1 comment
Closed

Call to ESMF_initialize should allow for no PET logfiles #1245

gold2718 opened this issue Mar 14, 2017 · 1 comment
Assignees
@gold2718

Comments

@gold2718
Copy link

While the default ESMF_initialize is a stub, when building with the ESMF library, a logfile is written for every PET. I propose that we add a driver namelist variable (drv_esmf_logkind?) to control logging by ESMF. The input would be ignored for the stub.
@rljacob rljacob added the ready label Mar 17, 2017
@gold2718 gold2718 mentioned this issue Mar 30, 2017
Merged
@ghost ghost added in progress and removed ready labels Mar 30, 2017
@ghost ghost removed the in progress label Mar 31, 2017
mvertens added a commit that referenced this issue Mar 31, 2017
@mvertens
Merge pull request #1289 from gold2718/esmfLog
0d320ec 
Added log kind flag to ESMF_Initialize call to allow control over ESMF PET log files when the ESMF library is used. The flag determines what ESMF log files (if any) are generated when USE_ESMF_LIB is TRUE.

ESMF_LOGKIND_SINGLE: Use a single log file, combining messages from all of the PETs. Not supported on some platforms.
ESMF_LOGKIND_MULTI: Use multiple log files -- one per PET.
ESMF_LOGKIND_NONE: Do not issue messages to a log file.
By default, no ESMF log files are generated.
Test suite: ./scripts_regression_test.py + hand testing:

./create_newcase --case /glade/scratch/goldy/esmfTest --compset A --res ne16_ne16 --run-unsupported
./xmlchange USE_ESMF_LIB=TRUE,DOUT_S=FALSE,STOP_OPTION=nsteps,STOP_N=3
Run test with each ESMF log kind option
Test baseline: NA
Test namelist changes: New driver namelist variable: esmf_logging
Test status: bit for bit

Fixes #1245

User interface changes?: New run time XML variable: ESMF_LOGFILE_KIND

Code review:
@gold2718
Copy link
Author

gold2718 commented Apr 3, 2017

The CESM driver treats its namelist file as optional, extend this behavior to new ESMF logging option.

@gold2718 gold2718 reopened this Apr 3, 2017
@gold2718 gold2718 mentioned this issue Apr 3, 2017
Merged
@ghost ghost added the in progress label Apr 3, 2017
@ghost ghost removed the in progress label Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gold2718 gold2718

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rljacob @gold2718