Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

machine name in test name not taking precedence. #1417

Closed
rljacob opened this issue Apr 25, 2017 · 1 comment
Closed

machine name in test name not taking precedence. #1417

rljacob opened this issue Apr 25, 2017 · 1 comment
Assignees
@jgfouca
Labels
tp: system tests tp: user interface ty: Bug

Comments

@rljacob
Copy link
Member

rljacob commented Apr 25, 2017 •
edited
Loading

We now allow several "machines" to be defined on the same host. Example: cori-knl and cori-haswell. Also blues and anvil. When using the testname to specify the machine, an error results if the machine is not the same as the host.

Example:

./create_test ERS.T62_oEC60to30v3.GMPAS-IAF.anvil_intel
ERROR: Mismatch in field machine, partial string 'ERS.T62_oEC60to30v3.GMPAS-IAF.anvil_intel' indicated it should be 'anvil' but you provided 'blues'

The error message is confusing. The user provided 'anvil' but the regex of the host points to 'blues'.

create_test should respect the use of 'anvil' in the test name and try to build a test with anvil as the machine.

Reported by @jonbob on ACME.
@rljacob
Copy link
Member Author

rljacob commented Apr 25, 2017

There are some easy ways to work around this.

Use command line options for the machine:
./create_test ERS.T62_oEC60to30v3.GMPAS-IAF --machine=anvil --compiler=intel

More hacky: Edit the machine's entry in config_machine so REGEX matches nothing.
On blues (hostname 'blogin'):

-         <NODENAME_REGEX>b.*.lcrc.anl.gov</NODENAME_REGEX>
+         <NODENAME_REGEX>d.*.lcrc.anl.gov</NODENAME_REGEX>

@rljacob rljacob mentioned this issue Apr 25, 2017
Closed
@jgfouca jgfouca self-assigned this May 10, 2017
@jgfouca jgfouca added the ready label May 10, 2017
@jgfouca jgfouca mentioned this issue May 24, 2017
Merged
jedwards4b added a commit that referenced this issue May 24, 2017
@jedwards4b
Merge pull request #1597 from ESMCI/jgfouca/infer_machine_from_tests
7003fe2 
Add ability for create_test to infer non-default machine from tests
Test suite: scripts_regression_tests --fast
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1417

User interface changes?: None

Code review: @jedwards4b
@ghost ghost removed the ready label May 24, 2017
jgfouca pushed a commit that referenced this issue Jun 2, 2017
@amametjanov
Merge branch 'worleyph/cime/update_provenance_collection' (PR #1429)
c37feff 
Update provenance data collection:
a) Update mach_syslog for other platforms to match that for Anvil

When adding mach_syslog for Anvil, the logic was refactored,
decreasing the amount of data collected. Introduce similar changes
for mach_syslog for the other systems. The system-specific
commands are querying system and job status were also examined,
and some of the command choices and options modified.

b) Modify collection of provenance data on all supported systems

Disable collection of xtdb2proc and mdiag system configuration
data and qstat -f system load data or Titan. (May want to re-enable
in the future, so just commenting out, not deleting.)

Eliminate collection of some redundant or irrelevant date on SLURM
systems at NERSC, and add collection of some data on system
configuration and node usage by other jobs. Also fix error caused
by changed name of ACME job script output on NERSC systems.

Anvil support in provenance.py was lost inadvertently. Add it
back. Also eliminate some unnecessary detail in the provenance data
collected on Anvil.

Eliminate some unnecessary detail in the provenance data collected
on Mira and Cetus.

[BFB]

Fixes #1417
jgfouca pushed a commit that referenced this issue Feb 23, 2018
@amametjanov
Merge branch 'worleyph/cime/update_provenance_collection' (PR #1429)
8503285 
Update provenance data collection:
a) Update mach_syslog for other platforms to match that for Anvil

When adding mach_syslog for Anvil, the logic was refactored,
decreasing the amount of data collected. Introduce similar changes
for mach_syslog for the other systems. The system-specific
commands are querying system and job status were also examined,
and some of the command choices and options modified.

b) Modify collection of provenance data on all supported systems

Disable collection of xtdb2proc and mdiag system configuration
data and qstat -f system load data or Titan. (May want to re-enable
in the future, so just commenting out, not deleting.)

Eliminate collection of some redundant or irrelevant date on SLURM
systems at NERSC, and add collection of some data on system
configuration and node usage by other jobs. Also fix error caused
by changed name of ACME job script output on NERSC systems.

Anvil support in provenance.py was lost inadvertently. Add it
back. Also eliminate some unnecessary detail in the provenance data
collected on Anvil.

Eliminate some unnecessary detail in the provenance data collected
on Mira and Cetus.

[BFB]

Fixes #1417
jgfouca pushed a commit that referenced this issue Mar 13, 2018
@amametjanov
Merge branch 'worleyph/cime/update_provenance_collection' (PR #1429)
b5c009e 
Update provenance data collection:
a) Update mach_syslog for other platforms to match that for Anvil

When adding mach_syslog for Anvil, the logic was refactored,
decreasing the amount of data collected. Introduce similar changes
for mach_syslog for the other systems. The system-specific
commands are querying system and job status were also examined,
and some of the command choices and options modified.

b) Modify collection of provenance data on all supported systems

Disable collection of xtdb2proc and mdiag system configuration
data and qstat -f system load data or Titan. (May want to re-enable
in the future, so just commenting out, not deleting.)

Eliminate collection of some redundant or irrelevant date on SLURM
systems at NERSC, and add collection of some data on system
configuration and node usage by other jobs. Also fix error caused
by changed name of ACME job script output on NERSC systems.

Anvil support in provenance.py was lost inadvertently. Add it
back. Also eliminate some unnecessary detail in the provenance data
collected on Anvil.

Eliminate some unnecessary detail in the provenance data collected
on Mira and Cetus.

[BFB]

Fixes #1417
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgfouca jgfouca

Labels
tp: system tests tp: user interface ty: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rljacob @jgfouca