-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SystemTestsCompareTwo multisubmit tries to do too much in phase 1 #1856
Labels
Comments
Merged
jgfouca
added a commit
that referenced
this issue
Sep 1, 2017
Erp to restart tests merge new erp test into new restart_tests abstract class, fix indentation in system_test_compare_two Test suite: scripts_regression_tests.py Test baseline: Test namelist changes: Test status: bit for bit Fixes #1856 Update gh-pages html (Y/N)?: Code review:
jgfouca
pushed a commit
that referenced
this issue
Nov 7, 2017
Update PEs for ne30 runs on Cetus/Mira: * Update ne30-grid PEs on Mira/Cetus * faster default 128x16x4 PE layout with 0.88 sypd for ne30-wcycl case * Reduce stacksize to 16M for 16 mpi-per-node to avoid OOM errors * Relax XML schema for env-var attributes to enable matching to arbitrary case-vars with xmllint * Switch ne120-atm compset from FC5AV1C-L to FC5AV1C-H01A [BFB]
jgfouca
pushed a commit
that referenced
this issue
Feb 23, 2018
Update PEs for ne30 runs on Cetus/Mira: * Update ne30-grid PEs on Mira/Cetus * faster default 128x16x4 PE layout with 0.88 sypd for ne30-wcycl case * Reduce stacksize to 16M for 16 mpi-per-node to avoid OOM errors * Relax XML schema for env-var attributes to enable matching to arbitrary case-vars with xmllint * Switch ne120-atm compset from FC5AV1C-L to FC5AV1C-H01A [BFB]
jgfouca
pushed a commit
that referenced
this issue
Mar 13, 2018
Update PEs for ne30 runs on Cetus/Mira: * Update ne30-grid PEs on Mira/Cetus * faster default 128x16x4 PE layout with 0.88 sypd for ne30-wcycl case * Reduce stacksize to 16M for 16 mpi-per-node to avoid OOM errors * Relax XML schema for env-var attributes to enable matching to arbitrary case-vars with xmllint * Switch ne120-atm compset from FC5AV1C-L to FC5AV1C-H01A [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In comparing #1830 with what made it to master, I noticed that the indentation of this block is wrong:
-- this should be indented under the "Second run" conditional.
The current indentation leads the ERR test (and any other multi-submit test) to try to do component_compare_test after the first phase, leading to a FAIL result. This doesn't cause a test failure, because the FAIL is later overwritten with a PASS, but it is still incorrect.
I have a fix for this in an incoming PR.
The text was updated successfully, but these errors were encountered: