Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V3 config_machines.xml doesn't consider user .cime directory for machine configs #4568

Closed
jasonb5 opened this issue Jan 22, 2024 · 0 comments · Fixed by #4569
Closed

V3 config_machines.xml doesn't consider user .cime directory for machine configs #4568

jasonb5 opened this issue Jan 22, 2024 · 0 comments · Fixed by #4569
Assignees
@jasonb5

Comments

@jasonb5
Copy link
Collaborator

jasonb5 commented Jan 22, 2024

If there's a V3 config_machines.xml under ~/.cime/, CIME will check for $SRCROOT/ccs_config/machines/docker/config_machines.xml and not ~/.cime/docker/config_machines.xml.

Issue is in set_machine function:

cime/CIME/XML/machines.py

Lines 320 to 328 in d2ec81a

machines_file = os.path.join(
self.machines_dir, machine, "config_machines.xml"
)
if os.path.isfile(machines_file):
GenericXML.read(
self,
machines_file,
schema=schema,
)

Should also consider ~/.cime/docker/config_machines.xml.
@jasonb5 jasonb5 self-assigned this Jan 22, 2024
@jedwards4b jedwards4b mentioned this issue Jan 22, 2024
Merged
jasonb5 added a commit that referenced this issue Jan 24, 2024
@jasonb5
Merge pull request #4569 from jedwards4b/machines_v3_fix
7b0bd56 
Add read of .cime/machine/config_machines.xml file if it exists.

Test suite: Hand testing with and without .cime/machine/config_machines.xml
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #4568

User interface changes?:

Update gh-pages html (Y/N)?:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonb5 jasonb5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

check .cime for a machine directory first jedwards4b/cime
1 participant
@jasonb5