Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unset environment variables after module purge #771

Closed
singhbalwinder opened this issue Nov 4, 2016 · 3 comments
Closed

unset environment variables after module purge #771

singhbalwinder opened this issue Nov 4, 2016 · 3 comments

Comments

@singhbalwinder
Copy link
Contributor

I often use the following sequence of commands in my machines files:

module purge
unsetenv LD_LIBRARY_PATH

....load modules for specific compiler/netcdf/mpi

In principle, LD_LIBRARY_PATH should have no entries after module purge command. However, it is not always the case. For example, if a user manually adds something to LD_LIBRARY_PATH, it wont be removed by module purge. In some cases, users may load modules in such a sequence that module purge may not be able to clear entries in LD_LIBRARY_PATH. I come across these issues quite often and un-setting LD_LIBRARY_PATH variable almost always resolves these kind of issues.

Right now, we cannot unset a variables to achieve the above sequence of commands.

I am also interested in knowing if other folks have encountered this issue and if they have a better solution.

@apcraig
Copy link
Collaborator

apcraig commented Aug 23, 2017

There is also a need to allow relatively arbitrary strings in the env_mach_specific file. This was easily possible in the past when this file was a simple shell scripts. It also was extremely easy for users to modify this file and for port testing to be carried out when it was simpler. In particular, we need

limit coredumpsize unlimited
limit stacksize unlimited

for some machines, but there could be a lot of others things that might be needed. It is critical that the env_mach_specific equivalent file can be setup as needed with a significant amount of flexibility such that the model can be used out of the box without any problems. There should never be settings required in the local user login scripts. It should also be easy for users to set this up when porting or for users to modify the file in cases where the underlying machine system setup has changed and the file needs to be modified.

jgfouca added a commit that referenced this issue Aug 29, 2017
allow user to adjust ulimits

Adds a resource limits section to config_machines.xml allowing the user to adjust environment ulimits

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Addresses #771

User interface changes?:

Update gh-pages html (Y/N)?:

Code review:
@billsacks
Copy link
Member

This has had the "critical" label for nearly 6 months. #1847 "addressed" it, but doesn't say it fixed it. Is this still a critical issue?

@jgfouca
Copy link
Contributor

jgfouca commented Sep 26, 2018

Closing. Please reopen if you think addition work is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants