Make Machines.get_value more likely to return values of the correct type #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
force-pushed
the
jgfouca/machine_get_value_type
branch
from
27228ea to
314a93c
Compare
jedwards4b
approved these changes
Apr 17, 2017
jgfouca
pushed a commit
that referenced
this pull request
Jun 2, 2017
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
Guard against div-by-zero in memory baseline comparison: Fail the MEMCOMP phase if the baseline memory is zero. Fixes #1349 [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the behavior more similar to case.get_value, so we can hopefully avoid bugs like this in the future.
Test suite: scripts_regression_tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1358
User interface changes?: None
Code review: @jedwards4b