Errput may be empty string or None #1390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In either case, you want to inform the user using output instead of errput.
jedwards4b
approved these changes
Apr 20, 2017
jgfouca
added a commit
that referenced
this pull request
Jun 2, 2017
preview_namelists.create_namelists wasn't re-creating dirs ... and therefore did not handle the case where the user called case.build --clean-all. For most components, it didn't matter, but it did for CAM. Fixes #1390 [BFB] * jgfouca/cime/create_namelists_fix: preview_namelists.create_namelists was re-creating dirs
jgfouca
added a commit
that referenced
this pull request
Feb 23, 2018
preview_namelists.create_namelists wasn't re-creating dirs ... and therefore did not handle the case where the user called case.build --clean-all. For most components, it didn't matter, but it did for CAM. Fixes #1390 [BFB] * jgfouca/cime/create_namelists_fix: preview_namelists.create_namelists was re-creating dirs
jgfouca
added a commit
that referenced
this pull request
Mar 13, 2018
preview_namelists.create_namelists wasn't re-creating dirs ... and therefore did not handle the case where the user called case.build --clean-all. For most components, it didn't matter, but it did for CAM. Fixes #1390 [BFB] * jgfouca/cime/create_namelists_fix: preview_namelists.create_namelists was re-creating dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In either case, you want to inform the user using output
instead of errput. When user was adding combine_output=True,
errput was coming back as None, not "".
Test suite: scripts_regression_tests --fast
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]
User interface changes?: None
Code review: @jedwards4b