Improve user compset error checking #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
May 16, 2017
jgfouca
requested changes
May 16, 2017
|
Added a bunch of tests of primary component logic. |
|
That looks great, thanks! |
jgfouca
approved these changes
May 16, 2017
jgfouca
added a commit
that referenced
this pull request
Jun 2, 2017
Adds test mods for RTM=NULL [BFB] - Bit-For-Bit * origin/singhbalwinder/atm/rtm-null: Adds test mods for RTM=NULL
jgfouca
added a commit
that referenced
this pull request
Feb 23, 2018
Adds test mods for RTM=NULL [BFB] - Bit-For-Bit * origin/singhbalwinder/atm/rtm-null: Adds test mods for RTM=NULL
jgfouca
added a commit
that referenced
this pull request
Mar 13, 2018
Adds test mods for RTM=NULL [BFB] - Bit-For-Bit * origin/singhbalwinder/atm/rtm-null: Adds test mods for RTM=NULL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add individual component specs to README.case, determine pesfile for user-compsets if it is not provided. replace principle_component with primary_component.
Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #608
Fixes #714
User interface changes?:
Code review: