Python2 Strings to Python3 Strings #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
May 25, 2017
jedwards4b
reviewed
May 26, 2017
jedwards4b
force-pushed
the
erichlf/3strings
branch
from
d4ac0b7
to
7f884ec
Compare
|
I have rebased to master to resolve conflicts and ran scripts_regression_tests.py on cheyenne. |
|
@jedwards4b hmmm, so did I and it looks like it took your changes instead of mine. There was a place in wait_for_tests.py which had a repeated format, so I changed it in favor of using the indexed format. I wonder what happened to my push? |
|
Yep, now I can't pull. |
|
After a rebase you need to reset your local to the remote |
Made all initial string conversions and print conversion, however no testing has been done.
In the last commit I accidentally over wrote some work before I commited. This is still untested.
I have done a bunch of fixes after an initial test. There are still plenty more errors, but I wanted to handle a handful at a time.
After running pylint a few times I have addressed most of the glaring issues. Now it is time to run a full test suite.
All files now pass the pylint test. Onto scripts_regression_tests.py.
When I was converting strings I broke the test scripts. I have done a checkout of the original scripts to make sure things are working correctly. However, other things broke. I will probably start from the beginning and try small incremental changes first.
Had to do a massive bisection to find which files were causing failures. After extensive work I have corrected all issues and all tests pass.
Had to do a massive bisection to find which files were causing failures. After extensive work I have corrected all issues and all tests pass.
Changed it so that instead of repeating an item more than once in format.
we repeat the item in the string, e.g. {0} {0}...
|
Okay, hurry things are not conflicting. lol |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes all python2 style strings to python3 style strings. It does not change the scripts_regression_tests.py script nor the code_checker script.
Test suite: code_checker and scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1492
User interface changes?:
Code review: @jgfouca @jedwards4b