Fix a couple pylint issues. #1629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a critical problem in code_checker that caused it to filter too many files.
jgfouca
pushed a commit
that referenced
this pull request
Oct 17, 2017
Set RTM grid to null in grid longname for RRM configurations to turn off the river runoff model. Required input files do not exist for running RTM with the RRM grids, so previously this required manually setting RTM_MODE=NULL for RRM grids. Once PR #1629 are #1693 merged as well, the supported RRM grids (CONUS, TWP, and ENA) should run without further user intervention. For now, the user still needs to set CAM_DYCORE=se, due to issue #1357.
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
Set RTM grid to null in grid longname for RRM configurations to turn off the river runoff model. Required input files do not exist for running RTM with the RRM grids, so previously this required manually setting RTM_MODE=NULL for RRM grids. Once PR #1629 are #1693 merged as well, the supported RRM grids (CONUS, TWP, and ENA) should run without further user intervention. For now, the user still needs to set CAM_DYCORE=se, due to issue #1357.
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
Set RTM grid to null in grid longname for RRM configurations to turn off the river runoff model. Required input files do not exist for running RTM with the RRM grids, so previously this required manually setting RTM_MODE=NULL for RRM grids. Once PR #1629 are #1693 merged as well, the supported RRM grids (CONUS, TWP, and ENA) should run without further user intervention. For now, the user still needs to set CAM_DYCORE=se, due to issue #1357.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a critical problem in code_checker that caused it to filter too
many files.
Test suite: pylint, unit-tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes [CIME Github issue #]
User interface changes?: None
Code review: None