Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build scripts in source mods #1730

Merged
merged 9 commits into from
Jul 12, 2017

Conversation

jedwards4b
Copy link
Contributor

Allow the buildnml and buildlib scripts for each component to be located in the SourceMods subdirectories of the case. Clean up some of the buildlib structure.

Test suite: scripts_regression_tests.py, hand tests with files in SourceMods.
Test baseline:
Test namelist changes:
Test status: bit for bit

Fixes #1727

User interface changes?:

Update gh-pages html (Y/N)?:Y a minor change was made

Code review:

@jedwards4b jedwards4b force-pushed the build_scripts_in_SourceMods branch from 298d608 to 68f9e82 Compare July 12, 2017 13:23
Copy link
Contributor

@jgfouca jgfouca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice big reduction in LOC

@jgfouca jgfouca merged commit 69f0128 into ESMCI:master Jul 12, 2017
@jedwards4b jedwards4b deleted the build_scripts_in_SourceMods branch July 12, 2017 17:22
jgfouca pushed a commit that referenced this pull request Oct 17, 2017
This PR brings ACME's submodule pointer up to date with FATES master,
and also accommodates changes to the interface between the two models.
These interface changes are modest, and allow for new namelist entries to
lnd_in, and a new system of how fates interacts with the parameter file.

A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land
developer test list.

Fixes #1730

[non-BFB]
jgfouca pushed a commit that referenced this pull request Feb 23, 2018
This PR brings ACME's submodule pointer up to date with FATES master,
and also accommodates changes to the interface between the two models.
These interface changes are modest, and allow for new namelist entries to
lnd_in, and a new system of how fates interacts with the parameter file.

A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land
developer test list.

Fixes #1730

[non-BFB]
jgfouca pushed a commit that referenced this pull request Mar 13, 2018
This PR brings ACME's submodule pointer up to date with FATES master,
and also accommodates changes to the interface between the two models.
These interface changes are modest, and allow for new namelist entries to
lnd_in, and a new system of how fates interacts with the parameter file.

A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land
developer test list.

Fixes #1730

[non-BFB]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants