-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build scripts in source mods #1730
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
298d608
to
68f9e82
Compare
jgfouca
approved these changes
Jul 12, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice big reduction in LOC
jgfouca
pushed a commit
that referenced
this pull request
Oct 17, 2017
This PR brings ACME's submodule pointer up to date with FATES master, and also accommodates changes to the interface between the two models. These interface changes are modest, and allow for new namelist entries to lnd_in, and a new system of how fates interacts with the parameter file. A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land developer test list. Fixes #1730 [non-BFB]
jgfouca
pushed a commit
that referenced
this pull request
Feb 23, 2018
This PR brings ACME's submodule pointer up to date with FATES master, and also accommodates changes to the interface between the two models. These interface changes are modest, and allow for new namelist entries to lnd_in, and a new system of how fates interacts with the parameter file. A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land developer test list. Fixes #1730 [non-BFB]
jgfouca
pushed a commit
that referenced
this pull request
Mar 13, 2018
This PR brings ACME's submodule pointer up to date with FATES master, and also accommodates changes to the interface between the two models. These interface changes are modest, and allow for new namelist entries to lnd_in, and a new system of how fates interacts with the parameter file. A new test: ERP_Ld3.f45_f45.ICLM45ED","clm-fates", was added to the land developer test list. Fixes #1730 [non-BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the buildnml and buildlib scripts for each component to be located in the SourceMods subdirectories of the case. Clean up some of the buildlib structure.
Test suite: scripts_regression_tests.py, hand tests with files in SourceMods.
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1727
User interface changes?:
Update gh-pages html (Y/N)?:Y a minor change was made
Code review: