Iscompvar cleanup #1965
Merged
Iscompvar cleanup #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
approved these changes
Oct 16, 2017
scripts/lib/CIME/utils.py
Outdated
| @@ -1222,6 +1222,7 @@ def find_system_test(testname, case): | |||
|
|
|||
| if tdir is not None: | |||
| tdir = os.path.abspath(tdir) | |||
| print (tdir) | |||
jgfouca
approved these changes
Oct 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup of the compvar implementation. There was a confusion between component attributes which represented components (cam, datm, etc) vs those which represented component classes (ATM, LND, etc). I've renamed the attributes associated with component classes to be compclass instead of component. This change also allowed me to get rid of the explicit list of compvars in env_mach_pes.py and env_run.py
Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes:
User interface changes?:
Update gh-pages html (Y/N)?:
Code review: