Fix several data component issues

[mvertens]

This PR fixes several outstanding issues:

1. src/components/data_comps/dshare was moved to src/share/streams in order
   to resolved issue Discussion on new organization of shr_stream_mod and related code #1802.

2. For aquaplanet runs - the landmask was reset in docn_comp_mod.F90
   and in fact this does work if you are reading an input sst file as the
   aquaplanet forcing. The right place to put this is in
   shr_strdata_init.F90 right after the model grid is read in. An
   optional argument was introduced in shr_strdata_init.F90
   (reset_domain_mask) that will allow this in a backwards compatible manner.
   This resolves issue Q compset DOCN streams not zeroing land mask with SE dycore #1960.

3. If the data component domain file is equal to 'UNSET' the 'domainfile' namelist
   variable should be set to'null'which will assume that the model domain is contained
   in the first stream file. This resolves issue Case created even with no domain file #1937.

Test suite: scripts_regressions_tests
The following extra tests were also run on cheyenne and compared to cesm2_0_alpha07f:

ERI.T62_g16.C1850ECO.cheyenne_intel.pop-ecosys
ERI.T62_g37.G.cheyenne_intel.pop-cice
ERP_D_Ln9.f19_f19_mg17.QPC6.cheyenne_intel.cam-outfrq9s
ERP_D_Ln9.f19_f19_mg17.QSC6.cheyenne_intel.cam-outfrq9s
ERP_Ln9.f09_f09_mg17.F1850_DONOTUSE.cheyenne_intel.cam-outfrq9s
ERP_P180x2_D_Ld5.f19_g17_gl4.I1850Clm50BgcCropG.cheyenne_intel.clm-default
ERR.f45_g37_rx1.A.cheyenne_intel
ERS_IOP.T62_g16.CIAF.cheyenne_intel.pop-default
ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default
ERS_Lm3.T62_g16.AIAF.cheyenne_intel
ERS_Ly3.f09_g16_gl4.T1850G.cheyenne_intel

Test baseline: cesm2_0_alpha07b
Test namelist changes: none
Test status: bit for bit

Fixes #1802
Fixes #1960
Fixes #1937

User interface changes?: None
Update gh-pages html (Y/N)?:N
Code review:

[apcraig]

It looks like the dependency on the driver share code was not removed. I think that is important.

[mvertens]

This belongs in a separate PR. This PR only related to the data model share code. Please raise an issue for addressing the driver share code and what routines need to be moved.

…

On Wed, Oct 25, 2017 at 10:34 AM, Tony Craig ***@***.***> wrote: It looks like the dependency on the driver share code was not removed. I think that is important. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1987 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlxE7-IRlOYBUFL099veQR1_1EZJczJks5sv2MYgaJpZM4QFAr7> .

[mvertens]

We also need to be careful that driver share code that is different between nuopc and cesm is handled correctly. On Wed, Oct 25, 2017 at 11:05 AM, Mariana Vertenstein <mvertens@ucar.edu> wrote:

…

This belongs in a separate PR. This PR only related to the data model share code. Please raise an issue for addressing the driver share code and what routines need to be moved. On Wed, Oct 25, 2017 at 10:34 AM, Tony Craig ***@***.***> wrote: > It looks like the dependency on the driver share code was not removed. I > think that is important. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#1987 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AHlxE7-IRlOYBUFL099veQR1_1EZJczJks5sv2MYgaJpZM4QFAr7> > . >

[apcraig]

I am not raising a driver share code issue, I am raising an issue that is directly related to the shr stream code. It currently depends on driver share code. That dependency should be removed.

This is not difficult to do and was pointed out in issue #1802.

[mvertens]

You are right. That said - I would like to simply put this in another PR. Lots of other things were also fixed in this PR.

…

On Wed, Oct 25, 2017 at 11:08 AM, Tony Craig ***@***.***> wrote: I am not raising a driver share code issue, I am raising an issue that is directly related to the shr stream code. It currently depends on driver share code. That dependency should be removed. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1987 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHlxE3jvmr184wlndCD9s15nrnVE4a5kks5sv2sNgaJpZM4QFAr7> .