Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better errormsg for compsets #2027

Merged
merged 4 commits into from
Nov 6, 2017

Conversation

jedwards4b
Copy link
Contributor

@jedwards4b jedwards4b commented Nov 3, 2017

Improve error messages for compset match

Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #1860
Fixes #1859
User interface changes?:

Update gh-pages html (Y/N)?:

Code review:

Copy link
Member

@billsacks billsacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this - this is definitely an improvement.

For use cases (1) and (2) in #1860 would it be possible to print out the portion of the compset string in error? i.e., for use case (1) the error message should explicitly call out "DATM2%NYF" as the portion in error, and for use case (2) the error message should explicitly call out "DATM%FOO" as the portion in error. With some careful reading, it's now possible to deduce this from the current error messages, but I feel it would help users if this were called out very clearly.

But if that's hard to do for some reason, I can let it go.

@jedwards4b
Copy link
Contributor Author

I didn't see a straightforward way to do that.

@billsacks
Copy link
Member

Okay, thanks for looking and thanks for your work on this.

@billsacks billsacks merged commit a84b875 into ESMCI:master Nov 6, 2017
@jedwards4b jedwards4b deleted the better_errormsg_for_compsets branch November 6, 2017 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants