updates for nersc systems #2147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgfouca
pushed a commit
that referenced
this pull request
Mar 27, 2018
Fix domain files setting for the CONUS RRM configuration. Specification of the domain files for the CONUS setup were missing from config_grids.xml, so hgrid was not being set, causing set_horiz_grid to fail during case setup. Adding specification of which domain files to use fixes this issue. Fixes #2147.
jgfouca
pushed a commit
that referenced
this pull request
Mar 27, 2018
Fix CONUS RRM configuration Fix two issues with the CONUS RRM configuration that prevented configuring a case with CONUS. First, the domain files were not specified for the CONUS grid in config_grids.xml, so hgrid ended up remaining UNSET, causing set_horiz_grid to fail with all components having grid values UNSET. This PR puts the domain file specification back into config_grids.xml for CONUS, and fixes #2147. Second, an older land initial condition (finidat) file was being used for sim year 2000 runs, which was incompatible with recent changes, causing runs to fail. This PR replaces finidat for sim year 2000 with the updated version. Fixes #1899 This PR also adds a test suite for RRM grids. [BFB]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module updates for cori and edison.
Test suite: scripts_regression_tests.py
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?:
Update gh-pages html (Y/N)?:
Code review: