-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support of DATM_MODE=CLM1PT for ELM #3845
Conversation
Modifications to support user-defined atmospheric forcing with ELM.
The new code in src/components/data_comps_mct/datm/cime_config/buildnml may not be an ideal solution, but I wanted to open this PR to get the conversation started on how to best accommodate these changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any problems with this.
It seems I broke a test. |
You did - do you know where to find the log? I also notice that you didn't run scripts_regression_tests.py locally for this PR. Can you please do that and update the initial comment of the conversation.
|
"A DATM_MODE for CLM is incompatible with DATM_TOPO=none.") | ||
expect(grid != "CLM_USRDAT" or clm_usrdat_name in ("", "UNSET"), | ||
"GRID=CLM_USRDAT and CLM_USRDAT_NAME is NOT set.") | ||
if get_model() != "e3sm": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks identical in both branches with the only difference being ELM vs CLM. You should capture this difference in a single string so the code can be reused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better, thanks.
@jgfouca this should be merged if you're happy with it. |
Modifications to support user-defined atmospheric forcing
with ELM.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?:
Code review: