Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes _find_gitroot for E3SM provenance #4254

Merged
merged 1 commit into from
May 11, 2022

Conversation

jasonb5
Copy link
Collaborator

@jasonb5 jasonb5 commented May 10, 2022

The function _find_gitroot would error when trying to determine the
models .git directory when being used as a submodule of another
project.

The error would occur when trying to copy a git metadata
file for provenance whose path was relative to the git repository.

This required two fixes, the first was to resolve the relative path and
the second was handling a third scenario for determining the model's
.git directory.

Test suite: scripts_regression_tests
Test baseline: n/a
Test namelist changes: n/a
Test status: n/a

Fixes #4251
User interface changes?: n
Update gh-pages html (Y/N)?: n

@jgfouca jgfouca self-assigned this May 11, 2022
@jgfouca jgfouca added Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM ty: Bug Fix labels May 11, 2022
@jgfouca jgfouca self-requested a review May 11, 2022 16:23
@jgfouca jgfouca merged commit d4ef5eb into ESMCI:master May 11, 2022
@jasonb5 jasonb5 deleted the fix_find_gitroot branch June 15, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Responsibility: E3SM Responsibility to manage and accomplish this issue is through E3SM ty: Bug Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provenance appears not to be handling relative paths correctly
2 participants