Gpu improvements #4334
Closed
Gpu improvements #4334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarats
reviewed
Nov 3, 2022
| if gpu_type != "none": | ||
| expect( | ||
| gpu_offload != "none", | ||
| "Both GPU_TYPE and GPU_OFFLOAD must be defined if either is", |
There was a problem hiding this comment.
Starting a discussion from E3SM perspective:
As this mandates GPU_OFFLOAD, we probably have to add a third option to handle the case for C++ codebases that use a library approach as it won't be OpenMP or OpenACC.
There was a problem hiding this comment.
Sarats - there is an ongoing discussion in #4334, I will copy this comment there.
sarats
reviewed
Nov 3, 2022
| compiler, ngpus_per_node | ||
| ), | ||
| ) | ||
| if gpu_type: |
There was a problem hiding this comment.
+1 on removing this init stub for ngpus as it makes the definition explicit.
|
superceeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new variables GPU_TYPE and GPU_OFFLOAD in cime so that special -gpu compiler definitions are no longer needed.
Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]
Fixes [CIME Github issue #]
User interface changes?:
Update gh-pages html (Y/N)?: