fix the restart tests by using ceil instead of int #4669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jasonb5 we continue to have trouble with black tests failing on files we didn't touch... |
|
@jedwards4b Hadn't pushed the PR that fixes it yet, I'll do that shortly. |
|
@jedwards4b #4670 will fix the pre-commit failure. See the PR description for an explanation. |
jgfouca
reviewed
Aug 29, 2024
|
No - I'll back that out. Thanks |
jgfouca
approved these changes
Aug 29, 2024
|
@jedwards4b This PR is causing several prealpha test failures. An example is ERS_Ly7.f09_g17_gris4.T1850Gg.derecho_intel. Traceback (most recent call last):
File "/glade/u/home/fischer/code/cesm3_0_alpha03b/cime/CIME/SystemTests/system_tests_common.py", line 351, in run
self.run_phase()
File "/glade/u/home/fischer/code/cesm3_0_alpha03b/cime/CIME/SystemTests/ers.py", line 53, in run_phase
self._ers_first_phase()
File "/glade/u/home/fischer/code/cesm3_0_alpha03b/cime/CIME/SystemTests/ers.py", line 19, in _ers_first_phase
self._rest_n = self._set_restart_interval()
File "/glade/u/home/fischer/code/cesm3_0_alpha03b/cime/CIME/SystemTests/system_tests_common.py", line 179, in _set_restart_interval
expect(stop_n > 0, "Bad STOP_N: {:d}".format(stop_n))
ValueError: Unknown format code 'd' for object of type 'float' |
|
Got it - fix coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
int was rounding down, but this calculation should round up.
Test suite: ERS.f19_g17.A.derecho_intel
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes #4667
User interface changes?:
Update gh-pages html (Y/N)?: