Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove distutils #4688

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Remove distutils #4688

merged 2 commits into from
Oct 1, 2024

Conversation

jedwards4b
Copy link
Contributor

distutils is deprecated in python 3.12 and needs to be removed.

Test suite:
Test baseline:
Test namelist changes:
Test status: [bit for bit, roundoff, climate changing]

Fixes [CIME Github issue #]

User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b requested a review from jasonb5 September 30, 2024 19:31
@jedwards4b jedwards4b self-assigned this Sep 30, 2024
@jedwards4b jedwards4b requested review from jgfouca and removed request for jasonb5 October 1, 2024 16:46
@jedwards4b jedwards4b merged commit 98fc664 into ESMCI:master Oct 1, 2024
6 of 7 checks passed
@jedwards4b
Copy link
Contributor Author

I think that there may be a problem with this change.

File "/glade/work/jedwards/sandboxes/cesm3/cime/CIME/utils.py", line 1412, in safe_copy                                                           
   shutil.copy2(                                                                                                                                   
 File "/glade/u/apps/derecho/23.09/opt/._view/uip25pncojubuf3qqtaj4uzay3xuwpie/lib/python3.10/shutil.py", line 434, in copy2                       
   copyfile(src, dst, follow_symlinks=follow_symlinks)                                                                                             
 File "/glade/u/apps/derecho/23.09/opt/._view/uip25pncojubuf3qqtaj4uzay3xuwpie/lib/python3.10/shutil.py", line 234, in copyfile                    
   raise SameFileError("{!r} and {!r} are the same file".format(src, dst))                                                                         
shutil.SameFileError: '/glade/derecho/scratch/jedwards/archive/ERI_Ly15.f09_g17_gris4.T1850Gg.derecho_intel.cism-isostasy_period4.C.20241001_132218\
_c5ds43.ref1/rest/0003-01-01-00000/rpointer.lnd.0003-01-01-00000' and '/glade/derecho/scratch/jedwards/ERI_Ly15.f09_g17_gris4.T1850Gg.derecho_intel\
.cism-isostasy_period4.C.20241001_132218_c5ds43.ref2/run/rpointer.lnd.0003-01-01-00000' are the same file   

@jgfouca
Copy link
Contributor

jgfouca commented Oct 2, 2024

@jedwards4b , maybe just add a line to check if it's the same file? There's no need to copy a file to itself.

@jedwards4b
Copy link
Contributor Author

Yes, fix incoming.

@jasonb5 jasonb5 deleted the remove_distutils branch October 3, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants