Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp to rpointers #4689

Merged
merged 23 commits into from
Dec 4, 2024

Conversation

jedwards4b
Copy link
Contributor

Modifies tests to allow for timestamps on rpointer files. Fully backward compatible to non-timestamped rpointers.

Test suite: cesm prealpha and prebeta tests
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?:

Update gh-pages html (Y/N)?:

@jedwards4b jedwards4b self-assigned this Oct 3, 2024
@jedwards4b jedwards4b marked this pull request as draft October 3, 2024 13:55
@jedwards4b jedwards4b requested a review from jasonb5 October 3, 2024 16:48
@jedwards4b jedwards4b marked this pull request as ready for review October 7, 2024 19:14
Copy link
Collaborator

@jasonb5 jasonb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rljacob
Copy link
Member

rljacob commented Oct 21, 2024

Are all these commits related to adding timestamps to rpointers? Doesn't look like it.

@rljacob
Copy link
Member

rljacob commented Oct 21, 2024

@jedwards4b it might be the merge of master in to this branch. You may want to rebase it instead. That gives a cleaner commit history.

@jedwards4b jedwards4b force-pushed the add_timestamp_to_rpointers branch from 9b68bbc to a320d61 Compare October 22, 2024 13:38
@jedwards4b
Copy link
Contributor Author

I've backed up and rebased - how does it look now?

@jedwards4b
Copy link
Contributor Author

It seems that the website https://web.lcrc.anl.gov/public/e3sm/inputdata/ is down.

@rljacob
Copy link
Member

rljacob commented Oct 22, 2024

Looks much better! We are looking in to the website issue.

@rljacob
Copy link
Member

rljacob commented Oct 23, 2024

website is fixed.

@jedwards4b jedwards4b force-pushed the add_timestamp_to_rpointers branch from a5d2b83 to c74e7a2 Compare October 23, 2024 15:47
@jedwards4b jedwards4b merged commit f285060 into ESMCI:master Dec 4, 2024
7 checks passed
@jedwards4b jedwards4b deleted the add_timestamp_to_rpointers branch December 4, 2024 20:27
@rljacob
Copy link
Member

rljacob commented Dec 5, 2024

Curious how this feature is being used.

@jedwards4b
Copy link
Contributor Author

By adding the timestamp to rpointer files it is much easier to restart from intermediate restart files. Currently in order to do this the rpointer files must be constructed by hand, an error prone and tedious step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants