This repository has been archived by the owner on Jun 1, 2019. It is now read-only.
New advertise/realize implementation in datm #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates a new advertise/realize implementation that is totally self contained within datm
and no longer depends on shr_nuopc_fldlist data types.
It also eliminates all calls to seq_timemgr_mod from datm_comp_mod and atm_comp_nuopc.
These type of changes will be implemented in future PRs to the other CIME data models.
Test suite: ran the following tests and verified that they did not change answers relative to the head of nuopc_cmeps
ERS_Vmct_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.hobart_intel
ERS_Vnuopc_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.hobart_intel
ERS_Vnuopc_Ln10.T62_g16.CMOM.hobart_intel
Used mvertens/app_cesm-cmeps UFSCOMP branch to carry this out
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?: No
Update gh-pages html (Y/N)?:
Code review: