Skip to content
This repository has been archived by the owner on Jun 1, 2019. It is now read-only.

New advertise/realize implementation in datm #20

Merged
merged 6 commits into from
Jul 31, 2018

Conversation

mvertens
Copy link
Contributor

This PR demonstrates a new advertise/realize implementation that is totally self contained within datm
and no longer depends on shr_nuopc_fldlist data types.
It also eliminates all calls to seq_timemgr_mod from datm_comp_mod and atm_comp_nuopc.
These type of changes will be implemented in future PRs to the other CIME data models.

Test suite: ran the following tests and verified that they did not change answers relative to the head of nuopc_cmeps
ERS_Vmct_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.hobart_intel
ERS_Vnuopc_Ln5.f45_f45_mg37.I2000Clm50SpNuopc.hobart_intel
ERS_Vnuopc_Ln10.T62_g16.CMOM.hobart_intel
Used mvertens/app_cesm-cmeps UFSCOMP branch to carry this out
Test baseline:
Test namelist changes:
Test status: bit for bit
Fixes
User interface changes?: No
Update gh-pages html (Y/N)?:
Code review:

@rsdunlapiv
Copy link
Collaborator

rsdunlapiv commented Jul 31, 2018

After accepting the request and merging there were compile errors:

 Case dir: /glade/scratch/dunlap/SMS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap.C.cmeps-ersC
    Errors were:
        Building test for SMS in directory /glade2/scratch2/dunlap/SMS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap.C.cmeps-ersC
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(195): error #6784: The number of actual arguments cannot be greater than the number of dummy arguments.   [DATM_COMP_INIT]
        
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(195): error #6633: The type of the actual argument differs from the type of the dummy argument.   [ECLOCK]
        
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(195): error #6630: By using keywords, an actual argument has been associated more than once with the same dummy argument.   [X2A]
        
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(195): error #6631: A non-optional actual argument must be present when invoking a procedure with an explicit interface.   [ATM_PROGNOSTIC]
        
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(327): error #6784: The number of actual arguments cannot be greater than the number of dummy arguments.   [DATM_COMP_RUN]
        
        /gpfs/u/home/dunlap/UFSCOMP.cmeps-july31/cime/src/components/data_comps/datm/mct/atm_comp_mct.F90(328): error #6627: This is an actual argument keyword name, and not a dummy argument name.   [ECLOCK]
        
        ERROR: BUILD FAIL: buildexe failed, cat /glade/scratch/dunlap/SMS_Vmct_Ld5.T62_g16.GMOM.cheyenne_intel.mom-nuopc_cap.C.cmeps-ersC/bld/cesm.bldlog.180731-151801

I traced the issue to needing to remove the first EClock parameter in calls to datm_comp_init() and datm_comp_run() in cime/src/components/data_comps/datm/mct/atm_comp_mct.F90. I restarted the test on Cheyenne. If they pass we'll leave this PR closed and I will push the fix directly to nuopc-cmeps.

@mvertens mvertens deleted the mvertens/advertise branch August 19, 2018 22:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants