Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pip!=21.3 to avoid pypa/pip#10573 with editable installs #1359

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Conversation

zklaus
Copy link

@zklaus zklaus commented Oct 15, 2021

Description

A recent update to pip introduced a regression that prevents running pip install -e for many projects, see pypa/pip#10573.
Here, we pin pip to avoid the problematic version; a fix is in the works in pypa/pip#10577.

Closes #1358


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@zklaus zklaus added bug Something isn't working deployment installation Installation problem labels Oct 15, 2021
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1359 (a714e80) into main (3c3f5cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1359   +/-   ##
=======================================
  Coverage   88.26%   88.26%           
=======================================
  Files         194      194           
  Lines        9836     9836           
=======================================
  Hits         8682     8682           
  Misses       1154     1154           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f5cb...a714e80. Read the comment docs.

@zklaus zklaus marked this pull request as ready for review October 15, 2021 09:30
@zklaus zklaus added this to the v2.4.0 milestone Oct 15, 2021
@zklaus zklaus merged commit 1422398 into main Oct 15, 2021
@zklaus zklaus deleted the pin-pip branch October 15, 2021 11:27
@bouweandela
Copy link
Member

Could you please do the same for the tool?

@zklaus
Copy link
Author

zklaus commented Oct 15, 2021

The PR is ESMValGroup/ESMValTool#2344. Just needs a bit of touch up, but working on the core release now.

@valeriupredoi
Copy link
Contributor

cheers @zklaus - sorry, was too late to approve but good thing Bouwe was on the ball 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working deployment installation Installation problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to install ESMValCore from source
3 participants