Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support linking to "stable" ESMValTool version on readthedocs #1608

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Conversation

bouweandela
Copy link
Member

@bouweandela bouweandela commented May 31, 2022

Description

This pull request should make linking/navigating from the "stable" version of the ESMValCore documentation to the stable version of the "ESMValTool" documentation work. It will probably only work after this has been merged and included in a release because the "stable" documentation is the same as the last released version.


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the documentation Improvements or additions to documentation label May 31, 2022
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #1608 (b8a69c9) into main (3149d07) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1608   +/-   ##
=======================================
  Coverage   91.16%   91.16%           
=======================================
  Files         202      202           
  Lines       10882    10882           
=======================================
  Hits         9921     9921           
  Misses        961      961           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bouweandela bouweandela changed the title Add "stable" version on readthedocs Support linking to "stable" ESMValTool version on readthedocs Oct 24, 2022
@bouweandela bouweandela marked this pull request as ready for review October 24, 2022 12:44
@bouweandela bouweandela added this to the v2.8.0 milestone Oct 24, 2022
@bouweandela
Copy link
Member Author

@ESMValGroup/technical-lead-development-team Anyone interested in reviewing this? It's a pretty small change.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since the TODO says that, and you did exactly that, I see dead people - I mean, I see no problem here 😁

@bouweandela bouweandela merged commit 7b91ec8 into main Nov 17, 2022
@bouweandela bouweandela deleted the doc branch November 17, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants