pin flake8<5.0.0 since Circle CI tests are failing copiously
#1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1698 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 204 204
Lines 11174 11174
=======================================
Hits 10224 10224
Misses 950 950 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
cheers, Manu! I should remind myself to have this pinned in the release as well (if we still need it, that is) |
|
opened this anyway - better safe and bureaucratic than Tom Cruise style 😁 conda-forge/esmvalcore-feedstock#48 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1696
Issues with the latest version of
flake8(>5) - not 100% what's happening at flake8 end, the PyCQA devs are not very keen on telling us muchBefore you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: