Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Icon hourly data rounding issues #2022

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

BauerJul
Copy link
Contributor

@BauerJul BauerJul commented May 11, 2023

Description

Fixed an issue with the ICON hourly fix_time function to get rid of some falsly hourly data, cause of rounding issues with the day fraction format ICON used, e.g. got 13:59:59 instead of 14:00:00 and also changed the test file to get exactly that tested.

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@codecov
Copy link

codecov bot commented May 11, 2023

Codecov Report

Merging #2022 (dc123df) into main (9c91bb3) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2022   +/-   ##
=======================================
  Coverage   92.78%   92.78%           
=======================================
  Files         236      236           
  Lines       12455    12455           
=======================================
  Hits        11556    11556           
  Misses        899      899           
Impacted Files Coverage Δ
esmvalcore/cmor/_fixes/icon/icon.py 100.00% <100.00%> (ø)

@schlunma schlunma self-requested a review May 11, 2023 13:29
@schlunma schlunma added the bug Something isn't working label May 11, 2023
@schlunma schlunma added this to the v2.9.0 milestone May 11, 2023
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julian, that looks good to me 🚀

@bouweandela bouweandela merged commit 664f7c9 into main May 11, 2023
@bouweandela bouweandela deleted the icon_fix_time_rounding branch May 11, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants