-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin pandas to avoid broken round
function
#2305
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2305 +/- ##
=======================================
Coverage 93.72% 93.72%
=======================================
Files 238 238
Lines 13122 13123 +1
=======================================
+ Hits 12299 12300 +1
Misses 823 823 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cheers, Manu! Always helpful to add refs to issue or PR numbers when we pin deps 👍
Co-authored-by: Valeriu Predoi <valeriu.predoi@gmail.com>
many thanks, Manu 🍺 |
Description
This PR fixes recent test failures that are caused by a bug in pandas. This bug breaks the
round
function that we use to round to the nearest second:ESMValCore/esmvalcore/cmor/_fixes/icon/icon.py
Lines 495 to 497 in d6008f3
In addition, this removes the use of two deprecated features:
DatetimeProperties.to_pydatetime
bynp.array
as recommended in the deprecation message. Unfortunately, this does not remove the warning, but hopefully this will avoid problems in the future.Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: